New Crowdin updates #613
New Crowdin updates #613
Conversation
WalkthroughThis pull request expands the localization data by adding new game content entries to multiple language JSON files. It introduces a new store item (“Melee Arcane Adapter”), five new challenge entries (including “Kill 500 Enemies,” “Shock and Awe” with its ability-related description, “Kill 75 Scaldra Troops with Melee Weapons,” “Purge the infection” for Techrot, and “Kill 200 Techrot with Abilities”), and four new upgrades (namely “Combo Wave,” “Tickshots,” “Overpower,” and “Psionic Feedback”). In several language files, an additional store package (“Vosfor Cache”) has also been added. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (35)
data/ru/languages.json (1)
47-55: Localized Store Item Addition: Verify Translation ConsistencyA new entry for
/Lotus/StoreItems/Types/Items/MiscItems/WeaponMeleeArcaneUnlockerhas been introduced with the value"Melee Arcane Adapter". Since this is the Russian localization file—and similar keys (like"WeaponSecondaryArcaneUnlocker") use localized strings—please confirm whether the new entry’s value should be translated into Russian for consistency.data/ko/languages.json (5)
47-55: New Store Item Entry: "Melee Arcane Adapter" Added Successfully
The new entry for/Lotus/StoreItems/Types/Items/MiscItems/WeaponMeleeArcaneUnlockerwith"value": "Melee Arcane Adapter"is correctly formatted and aligns with similar entries in other language files. Please verify that the naming convention for this item is consistent across all localizations.
297-305: Challenge Entry for "Kill 500 Enemies"
The new challenge entry at/Lotus/Types/Challenges/Calendar1999/CalendarKillEnemiesMediumwith"value": "Kill 500 Enemies"has been added. Note that it does not include a"desc"field, whereas many other challenge entries do. Please confirm if adding a description is optional or if a description (even if brief) should be added for consistency.
328-340: Duplicate Naming for "Shock and Awe" Challenges
In this hunk, two challenge entries related to Scaldra enemies both use the"value": "Shock and Awe"label, one with a description for abilities and one for melee kills. While the descriptions differ ("Kill 75 Scaldra Troops with Abilities" vs. later, "Kill 250 Scaldra Troops with Abilities"), the repeated title may reduce clarity. Please double‑check if distinct names are intended for these different challenges or if a unique name should be provided for one of them.
347-359: Techrot Challenge Updates Verification
The modifications for the Techrot challenges adjust both the objective counts and the titles:
- The entry at
/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesMediumnow shows"desc": "Kill 500 Techrot", which differs from the previous value of 1,000.- A new entry for
/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesWithAbilitiesMediumhas been added without a description.Please confirm that these changes reflect the new game design specifications. If a description is desired for the abilities challenge, consider adding one for consistency.
490-503: Upgrade Descriptions for "Overpower" and "Psionic Feedback" – Consider Rewording
The new upgrade entries for:
/Lotus/Upgrades/Calendar/PowerStrengthAndEfficiencyPerEnergySpentwith"value": "Overpower"and/Lotus/Upgrades/Calendar/RadiationProcOnTakeDamagewith"value": "Psionic Feedback"are correctly added. However, consider revising the descriptions for clarity:
Overpower: Instead of "Casting abilities increases ability strength by 2% and efficiency by -1% per unit of energy used by ability, for 5s.", a clearer wording might be:
"Casting abilities increases ability strength by 2% and decreases ability efficiency by 1% per unit of energy used, for 5s."Psionic Feedback: The current description "On Damaged 10% chance to set off a 250 damage, 5m radius blast of radiation on taking damage." could be improved to:
"Upon taking damage, there is a 10% chance to trigger a 250-damage, 5m radius radiation blast."These changes would improve readability and consistency in the upgrade descriptions.
data/es/languages.json (3)
50-52: New Store Item Entry Addition
A new store item key/Lotus/StoreItems/Types/Items/MiscItems/WeaponMeleeArcaneUnlockerhas been added with the value"Melee Arcane Adapter". Please verify that this value complies with your localization standards. In the Spanish file, consider if a Spanish translation is desired for consistency (e.g., similar to"Adaptador de Arcano Secundario"in another entry).
300-302: New Challenge: "Kill 500 Enemies"
The new challenge entry at/Lotus/Types/Challenges/Calendar1999/CalendarKillEnemiesMediumnow includes only a"value"field without a"desc". Please verify if a description is needed for consistency with similar challenge entries or if the omission is intentional.
493-500: Upgrades "Overpower" and "Psionic Feedback" Update
The upgrade for/Lotus/Upgrades/Calendar/PowerStrengthAndEfficiencyPerEnergySpentis now labeled"Overpower"with an updated description, and a new upgrade/Lotus/Upgrades/Calendar/RadiationProcOnTakeDamagewith the value"Psionic Feedback"has been added. Consider rephrasing the description for"Psionic Feedback"to improve clarity. For example, instead of"On Damaged 10% chance to set off a 250 damage, 5m radius blast of radiation on taking damage.", you could use:
"Upon taking damage, there is a 10% chance to trigger a 250-damage, 5m radius blast of radiation."
This revision will enhance readability and clarity for users.data/pt/languages.json (3)
300-302: Challenge Entry: "Kill 500 Enemies"
A new challenge under/Lotus/Types/Challenges/Calendar1999/CalendarKillEnemiesMediumhas been introduced with the value "Kill 500 Enemies". Consider whether a description is needed for consistency with similar entries; if not, confirm that an entry with only a value is the desired outcome.
350-356: Challenge Entries for Techrot Enemies
The hunk adjusts the "Purge the infection" challenge by adding a version with a different enemy kill count, and it introduces a new key for killing Techrot with Abilities without a description. Confirm that using the same name ("Purge the infection") for both 1,000 and 500 Techrot targets is deliberate, and consider adding a descriptive text for/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesWithAbilitiesMediumto maintain consistency with other challenges.
493-500: Upgrade Entries: "Overpower" and "Psionic Feedback"
The new entries for/Lotus/Upgrades/Calendar/PowerStrengthAndEfficiencyPerEnergySpent("Overpower") and/Lotus/Upgrades/Calendar/RadiationProcOnTakeDamage("Psionic Feedback") are correctly added. However, the descriptions could benefit from minor grammatical improvements for clarity. For example:- "desc": "Casting abilities increases ability strength by 2% and efficiency by -1% per unit of energy used by ability, for 5s." + "desc": "Casting abilities increases ability strength by 2% while reducing efficiency by 1% per unit of energy used, for 5 seconds."- "desc": "On Damaged 10% chance to set off a 250 damage, 5m radius blast of radiation on taking damage." + "desc": "When damaged, 10% chance to trigger a 250-damage blast of radiation with a 5m radius."These adjustments help improve readability and clarity.
data/cs/languages.json (3)
331-334: Challenge Naming – Abilities (Hard Difficulty)The new challenge entry for key
"/Lotus/Types/Challenges/Calendar1999/CalendarKillScaldraEnemiesWithAbilitiesHard"assigns the value"Shock and Awe"with a description"Kill 250 Scaldra Troops with Abilities". Since a similar title is used elsewhere (with a lower kill target), consider differentiating the title to clearly indicate the distinct difficulty tier and avoid user confusion.
493-496: Upgrade Description Clarity: "Overpower"The
"Overpower"upgrade entry under key"/Lotus/Upgrades/Calendar/PowerStrengthAndEfficiencyPerEnergySpent"includes the phrase"efficiency by -1%"in its description. Consider rephrasing for clarity—for example:
"Casting abilities increases ability strength by 2% and reduces efficiency by 1% per unit of energy used, for 5s."
497-500: Upgrade Description Clarity: "Psionic Feedback"The description for
"Psionic Feedback"starts with"On Damaged", which could be made clearer. A suggested rewording is:
"When taking damage, there is a 10% chance to trigger a 250 damage, 5m radius blast of radiation."data/fr/languages.json (1)
490-503: New Upgrades: Overpower and Psionic Feedback
Two new upgrade entries have been added:
- For
/Lotus/Upgrades/Calendar/PowerStrengthAndEfficiencyPerEnergySpent,"Overpower"is defined with a description that reads:"Casting abilities increases ability strength by 2% and efficiency by -1% per unit of energy used by ability, for 5s."Consider revising the phrase"efficiency by -1%"for clarity (for example, to indicate a reduction in efficiency) if this better conveys the intended effect.- For
/Lotus/Upgrades/Calendar/RadiationProcOnTakeDamage,"Psionic Feedback"is introduced with the description"On Damaged 10% chance to set off a 250 damage, 5m radius blast of radiation on taking damage."The phrasing here is a bit awkward; you might consider rewording it (e.g., “Upon taking damage, there is a 10% chance to trigger a 250-damage, 5m radius blast of radiation.”) for better clarity.Please verify that these descriptions match the game design and localization style guidelines.
data/uk/languages.json (8)
47-55: New Store Item Localization Consistency
The entry for/Lotus/StoreItems/Types/Items/MiscItems/WeaponMeleeArcaneUnlockeruses the English string"Melee Arcane Adapter". In a Ukrainian localization file, please confirm whether an appropriate Ukrainian translation is available or if it is intentionally kept in English.
297-303: Challenge Entry Style and Punctuation Check
The new challenge/Lotus/Types/Challenges/Calendar1999/CalendarKillEnemiesMediumhas the value"Убийте 500 ворогів."with a terminal period. Verify that the punctuation and style align with the rest of the challenge entries in this file.
328-340: Challenge Title and Localization Consistency
This hunk adds several Scaldra challenge entries. Notice that the title"Shock and Awe"is used for two different challenges with varying descriptions, and the language alternates between English and Ukrainian (e.g."Kill 75 Scaldra Troops with Abilities"vs."Особисте"). Please confirm that the mixed use of English and Ukrainian is intentional and consistent with your localization strategy.
347-359: Verify Consistent Localization in Techrot Challenges
In these entries, the initial challenge is localized ("Очищення інфекції","Убийте 100 техногнилих ворогів."), whereas subsequent challenges (such as/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesMediumand/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesWithAbilitiesMedium) remain in English. Please ensure that either all challenge entries are localized or that the mix is intentional.
394-402: New Store Package Translation Check
The entry for/Lotus/Types/StoreItems/Packages/Calendar/CalendarVosforPackhas the value"Vosfor Cache". As this is a Ukrainian language file, confirm if a local translation is required or if leaving it in English is acceptable for your use case.
454-463: Upgrade Entry Localization Review
The newly added upgrade/Lotus/Upgrades/Calendar/EnergyWavesOnComboprovides an English title and description ("Combo Wave"and its associated description). Please verify that either these entries are meant to remain in English or a Ukrainian translation should be provided to maintain consistency across the file.
466-475: Upgrade Entry Consistency Check
The upgrade/Lotus/Upgrades/Calendar/GuidingMissilesChanceis introduced with the English title"Tickshots"and an English description. Ensure that this, along with similar entries (e.g./Lotus/Upgrades/Calendar/HealingEffects), meets your localization standards for the Ukrainian file.
490-503: Review Upgrade Descriptions for Clarity and Localization
The new upgrade entries/Lotus/Upgrades/Calendar/PowerStrengthAndEfficiencyPerEnergySpentand/Lotus/Upgrades/Calendar/RadiationProcOnTakeDamagecontain English strings. For example,"Overpower"and"Psionic Feedback"along with their descriptions are not localized. Additionally, the phrasing (e.g.,"increases ability strength by 2% and efficiency by -1%") could be clearer. Consider rewording for clarity and ensuring consistency with localized content.data/sr/languages.json (2)
297-305: New Challenge for Killing Enemies
A new challenge entry for/Lotus/Types/Challenges/Calendar1999/CalendarKillEnemiesMediumis introduced with the value "Kill 500 Enemies". Note that no description is provided for this challenge. Please confirm if the omission of a"desc"key is intentional for consistency with similar entries.
328-337: Additional Scaldra Challenge Entries
Two new challenge entries are added:
/Lotus/Types/Challenges/Calendar1999/CalendarKillScaldraEnemiesWithAbilitiesHardnow has the value "Shock and Awe" with a description for killing 250 Scaldra Troops with Abilities./Lotus/Types/Challenges/Calendar1999/CalendarKillScaldraEnemiesWithMeleeEasywith the value "Kill 75 Scaldra Troops with Melee Weapons" is added without a description.Ensure that the naming and value formatting are consistent across similar challenge entries. If descriptions are generally provided, consider adding one for the melee challenge for clarity.
data/de/languages.json (2)
454-463: New Upgrade: Combo Wave
The upgrade entry/Lotus/Upgrades/Calendar/EnergyWavesOnCombois introduced with the value"Combo Wave"along with a descriptive effect. The description is clear; however, consider adding minor punctuation (e.g., a comma after "gaining 7x combo multiplier") to improve readability if it aligns with your style guidelines.
490-503: New Upgrades: Overpower and Psionic Feedback
The new upgrade entries for/Lotus/Upgrades/Calendar/PowerStrengthAndEfficiencyPerEnergySpent("Overpower") and/Lotus/Upgrades/Calendar/RadiationProcOnTakeDamage("Psionic Feedback") have been added as expected. Please review the phrasing in the"Psionic Feedback"description—phrases like “On Damaged” might read better as “When damaged” for clarity. Also, confirm that the percentage adjustments in"Overpower"correctly reflect the intended gameplay trade-offs.data/it/languages.json (2)
328-340: Challenge Variants: "Shock and Awe" Duplication
There are two entries using the display name "Shock and Awe": one with the description "Kill 75 Scaldra Troops with Abilities" and another with "Kill 250 Scaldra Troops with Abilities". If this duplication is intentional to represent different difficulty levels, consider differentiating the names (for example, by appending a difficulty indicator) to avoid confusion.
490-503: New Upgrades: "Overpower" & "Psionic Feedback" Modification
The addition of the upgrade/Lotus/Upgrades/Calendar/PowerStrengthAndEfficiencyPerEnergySpentwith the value "Overpower" and the new entry/Lotus/Upgrades/Calendar/RadiationProcOnTakeDamage("Psionic Feedback") are clear. However, the description for "Psionic Feedback" currently starts with "On Damaged" which is slightly ambiguous. For clarity and better grammatical flow, consider rephrasing it. For example:- "desc": "On Damaged 10% chance to set off a 250 damage, 5m radius blast of radiation on taking damage." + "desc": "Upon taking damage, there is a 10% chance to trigger a 250 damage blast with a 5m radius."This revision enhances clarity for end users.
data/tr/languages.json (1)
490-503: Phrasing Review for "Overpower" and "Psionic Feedback" Upgrades:
For the upgrade/Lotus/Upgrades/Calendar/PowerStrengthAndEfficiencyPerEnergySpent("Overpower"), the description currently reads:
"Casting abilities increases ability strength by 2% and efficiency by -1% per unit of energy used by ability, for 5s."
This phrasing may be confusing. Consider rephrasing it to something like:
"Casting abilities increases ability strength by 2% and reduces efficiency by 1% per unit of energy used, for 5s."Similarly, for the upgrade
/Lotus/Upgrades/Calendar/RadiationProcOnTakeDamage("Psionic Feedback"), the description
"On Damaged 10% chance to set off a 250 damage, 5m radius blast of radiation on taking damage."
could be improved for clarity. A suggestion is:
"Upon taking damage, there is a 10% chance to trigger a 250-damage, 5m radius radiation blast."These are cosmetic recommendations to enhance clarity for translators and developers alike.
data/zh/languages.json (3)
328-340: Review Challenge Duplication and Consistency.
The label "Shock and Awe" is used in multiple entries with differing descriptions (one for ability-based and another for melee-based challenges). Please ensure that reusing this label does not cause ambiguity in the game UI and that the descriptions accurately reflect the intended challenge difficulty.
347-359: Verify Techrot Challenge Adjustments.
The updates for Techrot challenges adjust enemy kill counts (e.g., from 1,000 to 500) and modify descriptions. Confirm that these changes are intentional. Additionally, consider adding a descriptive field for/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesWithAbilitiesMediumfor consistency with the other challenge entries.
490-503: Refine Upgrade Description for Clarity.
In the entry for/Lotus/Upgrades/Calendar/RadiationProcOnTakeDamage, the description begins with "On Damaged", which might be unclear. Consider rephrasing this description for clarity, for example: "Upon taking damage, there is a 10% chance to trigger a 250 damage blast over a 5m radius."data/pl/languages.json (1)
493-500: New Upgrade Entries: PowerStrengthAndEfficiencyPerEnergySpent & RadiationProcOnTakeDamage
Both upgrades are added as follows:
• "PowerStrengthAndEfficiencyPerEnergySpent" with value "Overpower" and description explaining ability strength and efficiency changes.
• "RadiationProcOnTakeDamage" with value "Psionic Feedback" describing a chance to trigger a radiation blast on taking damage.Consider reviewing the phrasing—particularly the term "On Damaged"—which might be clearer if reworded (e.g., "When damaged"). Additionally, double-check that a "-1%" efficiency modifier is intentional.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (13)
data/cs/languages.json(8 hunks)data/de/languages.json(8 hunks)data/es/languages.json(8 hunks)data/fr/languages.json(8 hunks)data/it/languages.json(8 hunks)data/ko/languages.json(8 hunks)data/pl/languages.json(8 hunks)data/pt/languages.json(8 hunks)data/ru/languages.json(8 hunks)data/sr/languages.json(8 hunks)data/tr/languages.json(8 hunks)data/uk/languages.json(8 hunks)data/zh/languages.json(8 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Summary
🔇 Additional comments (72)
data/ru/languages.json (7)
297-305: New Challenge Entry “Убейте 500 врагов”: Confirm Description OmittanceThe new challenge key
/Lotus/Types/Challenges/Calendar1999/CalendarKillEnemiesMediumis added with only a"value"property ("Убейте 500 врагов"). Please verify if omitting the"desc"property is intentional or if a description is expected to match the format of nearby challenge entries.
328-340: Scaldra Challenge Updates: Check Consistency of Descriptive FieldsIn this hunk, two challenge keys have been updated/added:
/Lotus/Types/Challenges/Calendar1999/CalendarKillScaldraEnemiesWithAbilitiesHardnow uses"Shock and Awe"with an updated description./Lotus/Types/Challenges/Calendar1999/CalendarKillScaldraEnemiesWithMeleeEasyis added with only a"value"property.Please verify if the omission of a description for the melee challenge and the changes in the ability-based challenge are in line with the localization guidelines and intended gameplay tone.
347-359: Techrot Challenge Adjustments: Confirm Update Intent and Field CompletenessThis hunk adjusts the “Purge the infection” challenge by:
- Changing the target of
/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesMediumfrom killing 1,000 Techrot to 500 Techrot.- Adding
/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesWithAbilitiesMediumwith the value"Kill 200 Techrot with Abilities"(without a"desc"property).Please verify that these modifications meet the game design requirements and that the lack of a description on the new abilities-related challenge is intended.
394-402: New Store Package “Vosfor Cache”: Verify Localization ChoiceThe addition of
/Lotus/Types/StoreItems/Packages/Calendar/CalendarVosforPackwith the value"Vosfor Cache"has been made. Considering the file’s language is Russian, confirm whether the proper noun should remain in English or be localized accordingly.
454-463: Upgrade Addition “Combo Wave”: Localization and Clarity CheckThe new upgrade
/Lotus/Upgrades/Calendar/EnergyWavesOnCombowith the value"Combo Wave"and its accompanying description have been added. Please verify that the English terminology aligns with localization expectations in this Russian file and that its style is consistent with other upgrade entries.
466-475: Upgrade Addition “Tickshots”: Verify Terminology ConsistencyThe upgrade
/Lotus/Upgrades/Calendar/GuidingMissilesChancenow uses the value"Tickshots"alongside its description. As similar upgrade entries are localized when needed, please confirm that leaving this term in English is intentional for the Russian language file.
490-503: New Upgrades “Overpower” and “Psionic Feedback”: Confirm Wording and LocalizationTwo new upgrade entries are introduced:
/Lotus/Upgrades/Calendar/PowerStrengthAndEfficiencyPerEnergySpentwith value"Overpower"and a description detailing a 2% increase in ability strength and a -1% efficiency penalty./Lotus/Upgrades/Calendar/RadiationProcOnTakeDamagewith value"Psionic Feedback"and its related description.Please verify that the specific wording (particularly the negative efficiency modifier) is correct and that both entries conform to the expected localization style for the Russian language file.
data/ko/languages.json (3)
394-402: Addition of Store Package "Vosfor Cache"
The new store package entry at/Lotus/Types/StoreItems/Packages/Calendar/CalendarVosforPackwith"value": "Vosfor Cache"follows the structure of similar entries. Ensure that the key naming and value match across all language files for uniformity.
454-463: New Upgrade "Combo Wave" Added
The upgrade entry at/Lotus/Upgrades/Calendar/EnergyWavesOnCombois properly formatted and the description clearly explains its effect. This addition aligns well with upcoming gameplay changes.
466-475: New Upgrade "Tickshots" Introduced
The entry for/Lotus/Upgrades/Calendar/GuidingMissilesChancewith"value": "Tickshots"and its associated description is clear and consistent with the established pattern for upgrade entries.data/es/languages.json (5)
331-337: Scaldra Challenge Update Review
The challenge entry for/Lotus/Types/Challenges/Calendar1999/CalendarKillScaldraEnemiesWithAbilitiesHardnow uses the same"value"("Shock and Awe") as an earlier entry but with an updated"desc"("Kill 250 Scaldra Troops with Abilities"). Additionally, a new challenge/Lotus/Types/Challenges/Calendar1999/CalendarKillScaldraEnemiesWithMeleeEasyis added. Please confirm that reusing the same title in different difficulty contexts is intentional and clear to users.
350-356: Techrot Challenge Adjustments
The challenge for/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesMediumhas been updated to show"Purge the infection"with a revised requirement (from killing 1,000 to 500 Techrot). In addition, the new challenge/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesWithAbilitiesMediumlacks a description. Please verify that these adjustments align with game design intentions and that the description omission for the abilities variant is deliberate.
397-399: New Store Package "Vosfor Cache" Addition
The new key/Lotus/Types/StoreItems/Packages/Calendar/CalendarVosforPackwith the value"Vosfor Cache"has been added. This entry appears to follow the established pattern. Just ensure that the naming and potential future localization remain consistent with other store package entries.
457-460: New Upgrade: "Combo Wave" Entry
The upgrade item/Lotus/Upgrades/Calendar/EnergyWavesOnCombois introduced with the value"Combo Wave"and a descriptive effect. The information appears consistent; please make sure that the in-game effect description fully reflects the intended behavior.
469-472: Upgrade Revision: "Tickshots" Update
The key/Lotus/Upgrades/Calendar/GuidingMissilesChancehas been updated to"Tickshots"with a revised description outlining projectile behavior. This update aligns well with the upgrade system—please confirm that the percentage adjustments match the game mechanics.data/pt/languages.json (5)
50-52: Store Item Entry: "Melee Arcane Adapter" Addition
The new store item entry is clearly added with the intended key and value. It follows the same structure as similar entries in the file. Ensure that corresponding changes in other language files remain consistent.
331-337: Challenge Entries for Scaldra Troops
There are additions for Scaldra-related challenges. Notice that the challenge name "Shock and Awe" is used twice with different descriptions (one for "Kill 75 Scaldra Troops with Abilities" and another for "Kill 250 Scaldra Troops with Abilities"). Please verify that this intentional reuse correctly reflects difficulty levels or game design requirements, so that it won’t confuse the players.
397-399: Store Package Entry: "Vosfor Cache"
The new store package key has been added with the value "Vosfor Cache." This aligns with the new content additions described in the PR objectives and is consistent with the structure used in similar entries.
457-460: Upgrade Entry: "Combo Wave"
The upgrade/Lotus/Upgrades/Calendar/EnergyWavesOnCombowith the value "Combo Wave" is added with a clear, descriptive text. The entry is well formatted and consistent with the other upgrade entries.
469-472: Upgrade Entry: "Tickshots"
The new upgrade for/Lotus/Upgrades/Calendar/GuidingMissilesChancenow uses the value "Tickshots" with a detailed description. The percentage values and explanation are clearly provided. Ensure these figures align with the game design metrics.data/cs/languages.json (8)
50-52: New Store Item Addition: "Melee Arcane Adapter"The new store item entry at key
"/Lotus/StoreItems/Types/Items/MiscItems/WeaponMeleeArcaneUnlocker"with value"Melee Arcane Adapter"is added correctly. Please ensure that this entry remains consistent with similar entries in other localization files.
300-302: New Challenge Entry: "Kill 500 Enemies"A new challenge entry under key
"/Lotus/Types/Challenges/Calendar1999/CalendarKillEnemiesMedium"with the value"Kill 500 Enemies"is introduced. Verify if a descriptive text should also be provided for consistency with other challenge entries.
335-337: New Melee Challenge AdditionThe challenge for key
"/Lotus/Types/Challenges/Calendar1999/CalendarKillScaldraEnemiesWithMeleeEasy"with the value"Kill 75 Scaldra Troops with Melee Weapons"is added correctly. The structure of the entry is consistent with other similar challenges.
350-353: Challenge Difficulty Adjustment for Techrot EnemiesThe challenge entry for key
"/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesMedium"now uses the value"Purge the infection"with a modified target description from"Kill 1,000 Techrot"to"Kill 500 Techrot". Please confirm that this change in target is intentional and aligns with the intended gameplay progression.
354-356: New Challenge Entry: "Kill 200 Techrot with Abilities"A new challenge entry is added for key
"/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesWithAbilitiesMedium"with the value"Kill 200 Techrot with Abilities". The entry is clear; just ensure that this new target fits the overall difficulty scaling.
397-399: New Store Package Addition: "Vosfor Cache"The new store package added under key
"/Lotus/Types/StoreItems/Packages/Calendar/CalendarVosforPack"with the value"Vosfor Cache"is correctly implemented. Confirm that the naming is consistent across all language files.
457-460: New Upgrade Addition: "Combo Wave"The upgrade
"Combo Wave"is introduced under key"/Lotus/Upgrades/Calendar/EnergyWavesOnCombo"with a clear description. Ensure that its effect and description are synchronized with similar upgrades in other localization files.
469-472: New Upgrade Addition: "Tickshots"The upgrade
"Tickshots"is added under key"/Lotus/Upgrades/Calendar/GuidingMissilesChance"along with its descriptive mechanics. The implementation is clear and aligns with the game’s upgrade structure.data/fr/languages.json (7)
47-55: New Miscellaneous Item Entry
The new entry for the key/Lotus/StoreItems/Types/Items/MiscItems/WeaponMeleeArcaneUnlockerwith the value"Melee Arcane Adapter"has been added. Please verify that the string remains in English intentionally for the French localization file, or confirm it should be translated.
297-305: New Challenge Entry for Enemy Kills
A new challenge entry under the key/Lotus/Types/Challenges/Calendar1999/CalendarKillEnemiesMediumwith the value"Kill 500 Enemies"has been introduced. Double-check that using the English text is intentional for the French locale (as similar entries in this file also appear in English) and that it follows the expected format.
328-337: New Scaldra Challenge Updates
This hunk adds multiple challenge entries for Scaldra enemies:
- The entry at line 328 uses
"Shock and Awe"with a description"Kill 75 Scaldra Troops with Abilities".- A new entry for
/Lotus/Types/Challenges/Calendar1999/CalendarKillScaldraEnemiesWithAbilitiesHardreuses"Shock and Awe"but describes the task as"Kill 250 Scaldra Troops with Abilities".- Additionally,
/Lotus/Types/Challenges/Calendar1999/CalendarKillScaldraEnemiesWithMeleeEasyis added with the value"Kill 75 Scaldra Troops with Melee Weapons".Please verify that reusing the title
"Shock and Awe"for differing difficulty levels is intentional and that the descriptions accurately reflect the challenge objectives.
347-359: Techrot Challenge Adjustments
The changes in this hunk modify the Techrot challenge:
- The entry previously labeled with
"Purge the infection"is now redefined under/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesMediumwith a new description"Kill 500 Techrot", suggesting a change in target count from 1,000 to 500.- A new entry for
/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesWithAbilitiesMediumis added with the value"Kill 200 Techrot with Abilities".Confirm that these modifications align with the intended game balance and challenge design.
394-402: New Store Package Addition
A new store package with the key/Lotus/Types/StoreItems/Packages/Calendar/CalendarVosforPackand value"Vosfor Cache"has been introduced. Ensure that this entry is consistent across all language files and that its naming follows the localization standards.
454-463: New Upgrade: Combo Wave
The upgrade entry for/Lotus/Upgrades/Calendar/EnergyWavesOnCombohas been added with the value"Combo Wave"and the description detailing that “upon gaining 7x combo multiplier all melee attacks fire off waves of energy.” Verify that the description’s phrasing and punctuation meet stylistic standards and the gameplay description is accurate.
466-475: New Upgrade: Tickshots
The new upgrade entry for/Lotus/Upgrades/Calendar/GuidingMissilesChanceintroduces"Tickshots"with a description explaining a 10% chance to fire a seeking projectile per hit and a reduction by 5% on firing. Please confirm that these mechanics are correctly represented and that the localization text is consistent with other upgrade entries.data/sr/languages.json (6)
47-55: New Miscellaneous Item Entry Added
The new entry for the store item under/Lotus/StoreItems/Types/Items/MiscItems/WeaponMeleeArcaneUnlockerwith the value "Melee Arcane Adapter" is correctly added and consistent with the overall localization update.
347-359: Techrot Challenge Adjustments
This hunk updates the Techrot challenges by modifying the description for/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesMediumfrom "Kill 1,000 Techrot" to "Kill 500 Techrot" and adds a new ability-based challenge/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesWithAbilitiesMediumwith the value "Kill 200 Techrot with Abilities".
Please verify that these changes reflect the intended gameplay balance adjustments and that they are consistent across all localization files.
394-402: Addition of New Store Package: Vosfor Cache
The addition of the new store package/Lotus/Types/StoreItems/Packages/Calendar/CalendarVosforPackwith the value "Vosfor Cache" is implemented as described in the PR summary. Ensure that this entry is also updated across the other language files for consistency.
454-463: New Upgrade Entry: Combo Wave
The new upgrade/Lotus/Upgrades/Calendar/EnergyWavesOnCombowith the value "Combo Wave" and its description is correctly added. This entry aligns with the enhancements described in the PR objectives.
466-473: New Upgrade Entry: Tickshots
The upgrade entry for/Lotus/Upgrades/Calendar/GuidingMissilesChanceis updated to "Tickshots" with an appropriate description. This change is consistent with the other upgrade updates in the PR.
490-503: Additional Upgrade Entries: Overpower and Psionic Feedback
The hunk adds two new upgrade entries:
/Lotus/Upgrades/Calendar/PowerStrengthAndEfficiencyPerEnergySpentwith the value "Overpower"/Lotus/Upgrades/Calendar/RadiationProcOnTakeDamagewith the value "Psionic Feedback"Both entries include descriptions that detail their in-game effects. The wording appears consistent with the style of previous entries. Verify that the phrasing (e.g., negative percentage for efficiency in "Overpower") is as intended from a game design perspective.
data/de/languages.json (6)
47-55: New Miscellaneous Item Entry Added
The new JSON entry for/Lotus/StoreItems/Types/Items/MiscItems/WeaponMeleeArcaneUnlockerwith the value"Melee Arcane Adapter"is correctly added and aligns with the localization update. Please verify that the naming convention is consistent with similar entries throughout your localization files.
297-305: New Challenge: Kill 500 Enemies
The challenge entry for/Lotus/Types/Challenges/Calendar1999/CalendarKillEnemiesMediumhas been introduced with the value"Kill 500 Enemies". Ensure that omitting a description here is intentional—if other challenges include one, consider adding a brief description for consistency.
328-340: Additional Scaldra Challenge Entries
The new challenge entries for Scaldra enemies, namely:
•/Lotus/Types/Challenges/Calendar1999/CalendarKillScaldraEnemiesWithAbilitiesHardwith"Shock and Awe"and"Kill 250 Scaldra Troops with Abilities", and
•/Lotus/Types/Challenges/Calendar1999/CalendarKillScaldraEnemiesWithMeleeEasywith"Kill 75 Scaldra Troops with Melee Weapons"
are added as per the PR objectives. Please double-check that having two entries with the same"Shock and Awe"label (one potentially pre-existing with a different objective) is intentional and not a duplication in naming.
347-359: Updated Techrot Challenge Targets
The challenge entry/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesMediumhas been updated from a"Kill 1,000 Techrot"target to"Kill 500 Techrot", and a new entry/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesWithAbilitiesMediumwith"Kill 200 Techrot with Abilities"is added. These modifications seem to align with the localization update; please confirm these adjustments are consistent with the intended game design.
394-402: New Store Package Entry Added
The addition of the store package/Lotus/Types/StoreItems/Packages/Calendar/CalendarVosforPackwith the value"Vosfor Cache"is correctly implemented. Verify that this entry follows the same structure and style as similar entries in other language files for uniformity.
466-475: New Upgrade: Tickshots Introduced
The entry/Lotus/Upgrades/Calendar/GuidingMissilesChanceis added for"Tickshots", complete with a descriptive explanation of its mechanic. The new upgrade is consistent with the objectives and clearly details the gameplay effect.data/it/languages.json (6)
47-55: New Item Entry: "Melee Arcane Adapter" Added
The entry for/Lotus/StoreItems/Types/Items/MiscItems/WeaponMeleeArcaneUnlockerwith the value "Melee Arcane Adapter" is correctly added. It follows the naming conventions used elsewhere in the localization files.
297-305: New Challenge Entry: "Kill 500 Enemies"
The new challenge under/Lotus/Types/Challenges/Calendar1999/CalendarKillEnemiesMediumwith the value "Kill 500 Enemies" has been inserted. Ensure this change is consistent with corresponding entries in other language files.
347-359: Updated Techrot Challenges
The challenge for/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesMediumnow uses "Purge the infection" with a revised description ("Kill 500 Techrot" instead of "Kill 1,000 Techrot"). In addition, the new entry for/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesWithAbilitiesMedium("Kill 200 Techrot with Abilities") is added. Please verify that these updated criteria have been reviewed and approved from a game-balance perspective.
394-402: New Store Package: "Vosfor Cache" Added
The addition of the/Lotus/Types/StoreItems/Packages/Calendar/CalendarVosforPackkey with the value "Vosfor Cache" is implemented correctly and is consistent with the file's structure.
454-463: New Upgrade: "Combo Wave" Introduced
The upgrade entry for/Lotus/Upgrades/Calendar/EnergyWavesOnCombowith the value "Combo Wave" and its description is clear and follows the established pattern for upgrade entries.
466-475: New Upgrade: "Tickshots" Added
The new upgrade under/Lotus/Upgrades/Calendar/GuidingMissilesChance("Tickshots") is added with a descriptive explanation. The description clearly explains the mechanics.data/tr/languages.json (7)
47-55: Store Item Addition:
The new localization entry for/Lotus/StoreItems/Types/Items/MiscItems/WeaponMeleeArcaneUnlockerwith the value"Melee Arcane Adapter"is added correctly and appears consistent with the updates in other language files.
297-302: Challenge Entry Addition for "Kill 500 Enemies":
A new challenge entry is introduced at/Lotus/Types/Challenges/Calendar1999/CalendarKillEnemiesMediumwith the value"Kill 500 Enemies". Please verify that this identifier and its label are consistent with similar entries across the localization files.
328-337: Verification of "Shock and Awe" Challenge Consistency:
There are two entries using the value"Shock and Awe"but with different descriptions—one with"Kill 75 Scaldra Troops with Abilities"and the other with"Kill 250 Scaldra Troops with Abilities". Please confirm that these distinctions are intentional and accurately reflect different challenge criteria.
347-359: Techrot Challenge Update Verification:
The challenge entry/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesMediumnow uses the value"Purge the infection"with a description adjusted to"Kill 500 Techrot", and a new abilities-specific challenge entry/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesWithAbilitiesMediumis introduced with the value"Kill 200 Techrot with Abilities". Please verify that these changes align with the intended gameplay adjustments.
394-402: Store Package Addition:
The new store package entry at/Lotus/Types/StoreItems/Packages/Calendar/CalendarVosforPackwith the value"Vosfor Cache"is added correctly. It appears consistent with similar additions in other language files.
454-463: Upgrade Entry Addition – "Combo Wave":
The upgrade entry/Lotus/Upgrades/Calendar/EnergyWavesOnCombowith the value"Combo Wave"and its description is clear and correctly localized.
466-472: Upgrade Entry Addition – "Tickshots":
The new upgrade entry/Lotus/Upgrades/Calendar/GuidingMissilesChancewith the value"Tickshots"and its description is well-formed. It would be good to double-check that the percentage values mentioned align with the gameplay design.data/zh/languages.json (5)
47-55: Verify Translation Localization Consistency.
The new entry for/Lotus/StoreItems/Types/Items/MiscItems/WeaponMeleeArcaneUnlockeradds the value "Melee Arcane Adapter". Since this is the Chinese locale file, please confirm if the value should be translated into Chinese—similar to other entries in this file.
297-305: Confirm Challenge Value Consistency.
The new challenge for/Lotus/Types/Challenges/Calendar1999/CalendarKillEnemiesMediumis set to "击杀500名敌人". Please verify that this value aligns with the game design requirements and is consistent with similar challenges across other locale files.
394-402: Check Store Item Localization.
The new store item/Lotus/Types/StoreItems/Packages/Calendar/CalendarVosforPackwith the value "Vosfor Cache" is introduced here. As with the earlier store item addition, verify whether the English text is acceptable in the Chinese localization or if it should be translated.
454-463: Evaluate Upgrade Entry Consistency.
The upgrade entry/Lotus/Upgrades/Calendar/EnergyWavesOnCombo("Combo Wave") has been added with a descriptive text. Please check that the text accurately reflects the intended gameplay mechanics and that its tone and style are consistent with other upgrade entries in the file.
466-475: Confirm Upgrade 'Tickshots' Entry Accuracy.
The upgrade for/Lotus/Upgrades/Calendar/GuidingMissilesChance("Tickshots") is now present. Ensure that the percentage values in its description are correct and that the key and value are properly localized as needed.data/pl/languages.json (7)
47-55: New Localization Entry: WeaponMeleeArcaneUnlocker
The new entry for the store item "Melee Arcane Adapter" is correctly added. Please verify that its key naming and value are consistent with similar entries across other language files.
297-305: New Challenge Entry: CalendarKillEnemiesMedium
The addition of the "CalendarKillEnemiesMedium" challenge with the value "Kill 500 Enemies" aligns with the PR objectives. Ensure that similar challenge entries in other language files are updated consistently.
331-337: Additional Scaldra Challenge Entries
Two new challenge entries are introduced for Scaldra enemies:
• For abilities: "CalendarKillScaldraEnemiesWithAbilitiesHard" with value "Shock and Awe" and description "Kill 250 Scaldra Troops with Abilities".
• For melee: "CalendarKillScaldraEnemiesWithMeleeEasy" with value "Kill 75 Scaldra Troops with Melee Weapons".
Please confirm that reusing "Shock and Awe" (which also appears in the previous entry with a different description) is intentional and does not cause ambiguity.
350-356: Revised Techrot Challenge Entries
The new entry for "CalendarKillTechrotEnemiesMedium" now has the value "Purge the infection" with an updated description ("Kill 500 Techrot"), and the new abilities challenge "CalendarKillTechrotEnemiesWithAbilitiesMedium" with value "Kill 200 Techrot with Abilities" is added. Confirm that reducing the Techrot count from 1,000 to 500 in this context is intended.
397-399: New Store Package Entry: CalendarVosforPack
The new store package entry with key "CalendarVosforPack" and value "Vosfor Cache" is added as described in the PR objectives. Ensure that this entry is correctly mirrored in the corresponding language files for consistency.
457-460: New Upgrade Entry: EnergyWavesOnCombo
The upgrade "EnergyWavesOnCombo" is correctly added with value "Combo Wave" and a detailed description. Verify that the description fits the intended gameplay mechanic and is consistent with other upgrade entries.
469-472: New Upgrade Entry: GuidingMissilesChance
The new upgrade "GuidingMissilesChance" with value "Tickshots" and its accompanying description have been correctly implemented. Please ensure consistency with similar upgrade entries across the localization files.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
data/zh/languages.json (1)
490-503: Upgrade Entries: Overpower & Psionic Feedback
The entries for/Lotus/Upgrades/Calendar/PowerStrengthAndEfficiencyPerEnergySpentand/Lotus/Upgrades/Calendar/RadiationProcOnTakeDamageare updated or added with values"Overpower"and"Psionic Feedback"respectively. The descriptions match the new upgrade details. As a nitpick, consider revisiting the punctuation and phrasing (e.g., “On Damaged 10% chance to set off a 250 damage, 5m radius blast of radiation on taking damage.”) for clarity if you have translation flexibility.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
data/zh/factionsData.json(1 hunks)data/zh/languages.json(9 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Summary
🔇 Additional comments (9)
data/zh/factionsData.json (1)
20-22: Translation Update for "FC_MITW"The value "墙中人" appropriately replaces the previous English text and reflects the intended localization update. Please ensure that this translation aligns with the approved Crowdin entries and follows consistency across other localized files.
data/zh/languages.json (8)
1-18: Review of Event & Quest Localization Updates
The updated event names and descriptions are correctly localized. The new values (e.g., "星日", "已封印热美亚裂缝", "行动代号：兽之腹", "不稳定微粒收集进度", and the detailed short event description) appear appropriate. Ensure consistency with other locale files if similar events exist.
47-55: New Store Item Entry Added
The addition of the/Lotus/StoreItems/Types/Items/MiscItems/WeaponMeleeArcaneUnlockerentry with the value"Melee Arcane Adapter"follows the update summary. Verify that this key aligns with other store item entries across languages and that the naming is consistent with in-game terminology.
297-303: New Challenge Entry for Enemies Medium
The new challenge/Lotus/Types/Challenges/Calendar1999/CalendarKillEnemiesMediumwith the value"击杀500名敌人"is correctly added. Note that the existing challenge/Lotus/Types/Challenges/Calendar1999/CalendarKillEnemiesWithAbilitiesHardremains unchanged in this hunk.
328-340: New Scaldra Challenges – Verify Descriptions and Differentiation
Two challenge entries related to Scaldra enemies have been added/updated:
- One entry (appearing in lines 328–330) shows
"value": "Shock and Awe"with"desc": "Kill 75 Scaldra Troops with Abilities".- Another entry
/Lotus/Types/Challenges/Calendar1999/CalendarKillScaldraEnemiesWithAbilitiesHard(lines 331–334) uses the same title but with the description"Kill 250 Scaldra Troops with Abilities".
Please verify that the intended design clearly differentiates these two challenges and that the descriptions (75 vs. 250 Troops) are correct as per game design.
347-359: Techrot Challenge Updates
The challenge/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesMediumhas been updated to reflect a lower kill requirement (from 1,000 to 500 Techrot), and the new ability-based challenge/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesWithAbilitiesMediumwith the value"Kill 200 Techrot with Abilities"is correctly introduced. Ensure that these changes are aligned with the game balance updates.
394-402: New Store Package Entry Added
The new store package/Lotus/Types/StoreItems/Packages/Calendar/CalendarVosforPackwith the value"Vosfor Cache"is added as expected. The insertion point among other store packages is appropriate.
454-463: Upgrade Entry Update: Combo Wave
The upgrade entry/Lotus/Upgrades/Calendar/EnergyWavesOnCombois updated with"value": "Combo Wave"and the corresponding description matches the intended design for a combo-based energy wave effect. Confirm that the adjacent entries (like the unchanged "Espresso Shots" and "Combo Killer") maintain consistency in style.
466-475: Upgrade Entry Update: Tickshots
The/Lotus/Upgrades/Calendar/GuidingMissilesChanceentry is now localized as"Tickshots"with an adjusted description. This update looks correct and conforms to the PR objectives.
|
Code Climate has analyzed commit 5cc061d and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
data/zh/languages.json (2)
1-18: Updated Event and Quest Translations with a Minor Typo Found
The new translations for event names and descriptions look consistent with the localization objectives. However, in the value for/Lotus/Language/JadeShadows/JadeShadowsShortEventDesc(line 15), there appears to be a repeated "的" ("...天王星上的的扬升任务..."). Please verify if this is a typo.
347-359: Updated Techrot Challenge Requirements
There is a modification for/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesMediumwhere the description changes from"Kill 1,000 Techrot"to"Kill 500 Techrot", and a new challenge/Lotus/Types/Challenges/Calendar1999/CalendarKillTechrotEnemiesWithAbilitiesMediumis added. Please verify that the reduction in the kill count requirement has been coordinated with game design expectations.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
data/zh/languages.json(9 hunks)data/zh/syndicatesData.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Summary
🔇 Additional comments (8)
data/zh/languages.json (7)
21-43: Revised Booster Pack and Store Item Entries
The updates for booster packs (e.g."赋能强化","赋能强化：双重组合包","裂罅") and store item names look correctly applied. Note that some values (such as"Javi's Scrawling") remain in English. Please confirm if this is intentional for the Chinese localization.
297-305: Addition of New Challenge: CalendarKillEnemiesMedium
The new challenge entry/Lotus/Types/Challenges/Calendar1999/CalendarKillEnemiesMediumwith the value"击杀500名敌人"is added as expected. Also, the challenge for/Lotus/Types/Challenges/Calendar1999/CalendarKillEnemiesWithAbilitiesHardstill exists with its original English texts—ensure that separate keys are intended and that any necessary localization differences are correct.
328-340: New Scaldra Challenge Entries Updated
The changes introduce a new challenge/Lotus/Types/Challenges/Calendar1999/CalendarKillScaldraEnemiesWithAbilitiesHardwith value"Shock and Awe"and description"Kill 250 Scaldra Troops with Abilities", as well as a new entry for/Lotus/Types/Challenges/Calendar1999/CalendarKillScaldraEnemiesWithMeleeEasy. Please confirm that these updated descriptions (and the contrasting abilities thresholds with the similar-sounding key in the previous hunk) are intended.
394-402: Addition of New Store Package: Vosfor Cache
The new store item/Lotus/Types/StoreItems/Packages/Calendar/CalendarVosforPackwith the value"Vosfor Cache"is introduced. Confirm whether the store item name should remain in English in the Chinese localization file or if a localized equivalent is desired.
454-463: New Upgrade for Energy Waves on Combo
The upgrade/Lotus/Upgrades/Calendar/EnergyWavesOnCombois introduced with the value"Combo Wave"and its corresponding description. Since this file targets Chinese localization, please verify that leaving these entries in English is intentional (for example, if they are brand names or otherwise not translated).
466-475: Introducing the 'Tickshots' Upgrade Entry
The changes add the upgrade/Lotus/Upgrades/Calendar/GuidingMissilesChancewith the value"Tickshots"and a detailed description. As with other upgrade entries, these remain in English. Confirm that this is the desired outcome for the Chinese localization context.
490-503: Addition of Overpower and Psionic Feedback Upgrades
The upgrades/Lotus/Upgrades/Calendar/PowerStrengthAndEfficiencyPerEnergySpentand/Lotus/Upgrades/Calendar/RadiationProcOnTakeDamageare added with the values"Overpower"and"Psionic Feedback", respectively, along with their descriptions. Please double-check if these should be translated or intentionally remain in English within the Chinese localization file.data/zh/syndicatesData.json (1)
80-82: Confirm Localization Update for EntratiLabSyndicateThe updated
"name": "科维兽"for theEntratiLabSyndicateentry aligns with the Crowdin updates. Please ensure that this translation is consistent with both the game’s internal terminology and other language files’ localization standards.
|
🎉 This PR is included in version 2.23.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary by CodeRabbit