Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node Tree section should probably include Attr #457

Open
cdumez opened this issue May 10, 2017 · 2 comments
Open

Node Tree section should probably include Attr #457

cdumez opened this issue May 10, 2017 · 2 comments

Comments

@cdumez
Copy link

cdumez commented May 10, 2017

The "Node Tree" section [1] should probably include Attr now that it is a Node again, no?

[1] https://dom.spec.whatwg.org/#node-trees
@annevk
Copy link
Member

annevk commented May 10, 2017

Yeah, it seems there's some mismatches there as Attr objects do identify as nodes.

@annevk
Copy link
Member

annevk commented Mar 13, 2018

This seems like a bigger problem actually. There's numerous methods that do not consider what should happen when an Attr node is passed.

This was referenced Mar 13, 2018
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cdumez @annevk