Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"create an event" actually needs to take a timestamp #606

Open
annevk opened this issue Mar 16, 2018 · 1 comment
Open

"create an event" actually needs to take a timestamp #606

annevk opened this issue Mar 16, 2018 · 1 comment

Comments

@annevk
Copy link
Member

annevk commented Mar 16, 2018

The current description

the time of the occurrence that the event is signaling

is rather handwavy and doesn't make sense for all callers (e.g., document.createEvent()). Updating all the callsites is tricky though.

@annevk
Copy link
Member Author

annevk commented Mar 16, 2018

I think we should make type an argument as well. I guess that means realm can no longer be optional though., but that doesn't seem too bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant