Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Persistence permission section #128

Closed
miketaylr opened this issue Nov 23, 2021 · 4 comments
Closed

Update Persistence permission section #128

miketaylr opened this issue Nov 23, 2021 · 4 comments

Comments

@miketaylr
Copy link
Member

As part of w3c/permissions#263, we're making sure all the powerful features are properly hooked up in each of their specs (w3c/permissions#329 tracks persistent-storage in particular).

Storage looks pretty good, there's a few busted links (I guess because Permissions was recently ported from bikeshed to respec? 🤷 ). And we can hook into https://w3c.github.io/permissions/#dfn-getting-the-current-permission-state as well.

This issue tracks that work - I'll send in a PR.

@annevk
Copy link
Member

annevk commented Nov 24, 2021

persistent-storage"'s permission state

This is probably wrong as "permission state" is only defined for a descriptor? (Not entirely sure how to phrase this instead though.)

Minor thing to fix: s/{{PermissionState/"granted"}}/"{{PermissionState/granted}}"/

@miketaylr
Copy link
Member Author

At the very bottom of https://w3c.github.io/permissions/#reading-current-states it says (kind of easy to miss):

As a shorthand, a PermissionName name's permission state is the permission state of a PermissionDescriptor with its name member set to name.

So we could leave it as is, or change the text to be something like:

"persistent-storage"'s permission state must have the same value for all environment settings objects with a given origin.

A {{PermissionDescriptor}} with its {{PermissionDescriptor/name}} set to "{{PermissionName/persistent-storage}}" must have the same <a>permission state</a> value for all <a>environment settings objects</a> with a given <a>origin</a>.

@annevk
Copy link
Member

annevk commented Nov 24, 2021

Ah okay, I guess that's okay then. Although it does seem a little weird in that permission state is also an algorithm. I'm not sure if it always was like that.

@miketaylr
Copy link
Member Author

Ah okay, I guess that's okay then.

So let's close this as "done-ish". (feel free to re-open if you disagree!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants