Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing non-existent constructors from MDN and BCD #1043

Closed
sideshowbarker opened this issue Jun 17, 2020 · 5 comments
Closed

Removing non-existent constructors from MDN and BCD #1043

sideshowbarker opened this issue Jun 17, 2020 · 5 comments

Comments

@sideshowbarker
Copy link
Member

sideshowbarker commented Jun 17, 2020 •
edited
Loading

MDN contains articles for the following constructors:

…and BCD also contains corresponding data for those constructors.

However, none of those constructors are actually in the spec.

So, should we delete the MDN articles and the corresponding data in BCD?
@ricea
Copy link
Collaborator

ricea commented Jun 17, 2020

I'm in favour of removing them from MDN.

@a2sheppy
Copy link

I've deleted the articles from MDN. @sideshowbarker is working on a PR to update the BCD records.

sideshowbarker added a commit to mdn/browser-compat-data that referenced this issue Jun 18, 2020
@sideshowbarker
Drop now-nonexistent Streams API constructors
ef7c2f8 
The constructors below are not in the current Streams spec.

* ReadableByteStreamController()
* ReadableStreamBYOBRequest()
* ReadableStreamDefaultController()
* WritableStreamDefaultController()

The BCD data showed that none of them had ever been implemented in any
browser engines — with the exception of ReadableStreamDefaultController(),
which the data indicated as being implemented in Firefox. But I think
that may have been incorrect — because I can’t find any evidence that
the constructor was ever actually implemented in Firefox.

See whatwg/streams#1043 for confirmation from
one of the spec editors that the constructors should be de-documented.
@sideshowbarker sideshowbarker mentioned this issue Jun 18, 2020
Merged
sideshowbarker added a commit to mdn/browser-compat-data that referenced this issue Jun 18, 2020
@sideshowbarker
Drop now-nonexistent Streams API constructors
c760196 
The constructors below are not in the current Streams spec.

* ReadableByteStreamController()
* ReadableStreamBYOBRequest()
* ReadableStreamDefaultController()
* WritableStreamDefaultController()

See whatwg/streams#1043 for confirmation from
one of the spec editors that the constructors should be de-documented.
@sideshowbarker
Copy link
Member Author

Raised mdn/browser-compat-data#6314 for the removal from BCD

@ricea
Copy link
Collaborator

ricea commented Jun 19, 2020

Thank you!

@sideshowbarker
Copy link
Member Author

@ricea Thanks for the confirmation (@MattiasBuelens too :)

Elchi3 pushed a commit to mdn/browser-compat-data that referenced this issue Jun 19, 2020
@sideshowbarker
Drop now-nonexistent Streams API constructors (#6314)
e20a8ee 
The constructors below are not in the current Streams spec.

* ReadableByteStreamController()
* ReadableStreamBYOBRequest()
* ReadableStreamDefaultController()
* WritableStreamDefaultController()

See whatwg/streams#1043 for confirmation from
one of the spec editors that the constructors should be de-documented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sideshowbarker @a2sheppy @ricea