-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any plan on supporting docker-compose #70
Comments
@arnav13081994 I thought about it and it would need many changes int he code, and as you can accomplish the same creating a step for each image you need to build based on the compose file, I decided it wasn't worth it. I am not telling I can't change my mind in the future. I will leave this open just in case I have some free time to give it a try and to see if there are more people interested. |
@whoan Yes, you are right. |
@whoan That sounds like a good option that would probably save a lot of headaches. Do you know if I build the images using this action separately, will this cache be used by docker compose afterwards? |
I tried to think of the different use cases reading from a compose file and having multiple images hosted in different registries is not an easy scenario to handle without many changes in the script. I still think that it's better to build individually and then the docker-compose build should take advantage of the cache created by the individual builds as long as you use the correct names in the compose file in subsequent steps of the same job (that is what happens if you build individually in your host and then run I will continue thinking on it though. |
hmm, this Action rocks!
So the ability to run I also tried to use this action but it seems to make my builds even slower than if I don't use any cache at all. I would appreciate if this is given some thought. |
Hi @NasAmin . Thanks for your feedback. |
@NasAmin @arnav13081994 @helloguille You can test the branch support-compose-files to see if it works for you. I made this test and seems to work fine. I will wait for some feedback to merge and release a new version (probably v5.8.0) |
I was wondering if there was any plan to support build images from docker-compose as well?
The text was updated successfully, but these errors were encountered: