Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to a non-gx package fails #33

Open
schomatis opened this issue Mar 21, 2018 · 1 comment
Open

Link to a non-gx package fails #33

schomatis opened this issue Mar 21, 2018 · 1 comment
Assignees

Comments

@schomatis
Copy link
Collaborator

schomatis commented Mar 21, 2018

(Edit: I'm rewriting this issue as I did a poor attempt at explaining it the last time.)

When trying to link to a package that doesn't support gx (i.e., it doesn't contain a package.json) the gx-go link command will fail while trying to install it (with gx install).

cd $GOPATH/src/github.com/ipfs/go-ipfs
make install

go get github.com/dgraph-io/badger
export BADGER_HASH=QmdKhi5wUQyV9i3GcTyfUmpfTntWjXu8DcyT9HyNbznYrn
gx-go link $BADGER_HASH
# ERROR: Error: error during gx install: exit status 1

# Temporary workaround: copy `package.json` from the gx release to the cloned repo
wget https://ipfs.io/ipfs/$BADGER_HASH/badger/package.json -O $GOPATH/src/github.com/dgraph-io/badger/package.json
gx-go link $BADGER_HASH
@schomatis schomatis changed the title Allow gx-go link not to install the linked package (it itself is not a package) Link to a non-gx package fails May 10, 2018
@whyrusleeping
Copy link
Owner

ooooh, yeah, thats annoying... Maybe we should have gx-go link detect that the target package doesnt have the package.json and perform that step for you automatically.

@schomatis schomatis self-assigned this Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants