Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Gif duration as framerate instead of duration #29

Open
wiheto opened this issue Apr 20, 2022 · 1 comment
Open

ENH Gif duration as framerate instead of duration #29

wiheto opened this issue Apr 20, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@wiheto
Copy link
Owner

wiheto commented Apr 20, 2022

Currently gif duration is in ms regardless of number of figures. Since gif will generally be combined with the frames argument, a gifframerate to replace gifduration is probably better.

Or at least as a possible alternative. So that if gifframerate is not None, gifduration = (framerate * 1000) * n_frames.

I think multiply with a 1000 cause framerate is natural in seconds and gifduration is currently in ms.

@wiheto wiheto added enhancement New feature or request good first issue Good for newcomers labels Apr 20, 2022
@wiheto
Copy link
Owner Author

wiheto commented Apr 20, 2022

Above was slightly inaccurate. This is not really the case, gifduration of a frame.

What is needed:

  • specify frames per second instead of duration of a single frame so gifduration = (1 / gifframerate) * 1000 is the conversion
  • fix documentation.

@wiheto wiheto mentioned this issue Mar 2, 2023
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant