Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Label nodes with ROI name #66

Open
neudorf opened this issue Jan 4, 2024 · 10 comments
Open

Feature Request: Label nodes with ROI name #66

neudorf opened this issue Jan 4, 2024 · 10 comments

Comments

@neudorf
Copy link

neudorf commented Jan 4, 2024

This looks like a great python alternative to other options (e.g., BrainNet Viewer). One feature that is helpful in BrainNet Viewer is the ability to add a text label to certain nodes in the figure. Is this a feature that could be added (or is this already implemented and I have missed it)?

Thanks so much.

@wiheto
Copy link
Owner

wiheto commented Jan 5, 2024

Hi,

So that feature does not currently exist. But can be added to the list (and can be added the next time a get round to releasing the next version).

Clarification question though: do you want the text on the node itself (very easy to implement), or do you want a line from the node to some empty space with the text (more challenging, but sounds fun)? Or both?

@wiheto
Copy link
Owner

wiheto commented Jan 5, 2024

So to make it clearer, would you rather like the figure on the left or the figure on the right (this one would need a lot more work obviously)

image

Obviously there will also be ways to limit the number of labels so it is not this many.

@diramigo
Copy link

I am interested in being able to add ROI labels to plots, especially if they don't overlap with the sphere center or replace the sphere. This is probably more useful when there are only a few nodes, but it still would be a nice addition

@edhutch1
Copy link

Hi, wondering whether this has been implemented? Would be a great feature!

@wiheto
Copy link
Owner

wiheto commented Aug 4, 2024

They are currently on the way:

#68

But I've been on holiday and haven't got around to fixing what went wrong with the tests.

@hasibagen
Copy link

I also look forward to this feature
Sometimes you need text next to each node to explain which node or brain area it is, especially when there are many nodes, I often can't tell which one it is
I look forward to the presentation of the diagram on the left. It would be great if the font could be smaller or avoid the circle of the node.
Thank you very much for your work.

@wiheto
Copy link
Owner

wiheto commented Sep 5, 2024

I will try and merge this within the next week but I need to check why the tests/continuous integration is failing. And I am just swamped at the moment to get round to this.

@wiheto
Copy link
Owner

wiheto commented Nov 29, 2024

Added

@wiheto wiheto closed this as completed Nov 29, 2024
@hasibagen
Copy link

I would like to ask if there is an API or related documentation for this new feature? I don’t seem to see it at https://www.netplotbrain.org/api/#node-keyword-arguments.

@wiheto
Copy link
Owner

wiheto commented Dec 4, 2024

Opps. I thought I added them but apparently I did not. I am still making some small fixes before pushing the latest verison to pypi. So I will add it in the coming days.

@wiheto wiheto reopened this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants