Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twig_Extension is deprecated #298

Closed
Vorta opened this issue Nov 22, 2019 · 1 comment · Fixed by #300
Closed

Twig_Extension is deprecated #298

Vorta opened this issue Nov 22, 2019 · 1 comment · Fixed by #300

Comments

@Vorta
Copy link

Vorta commented Nov 22, 2019

Hello!

The Hateoas\Twig\Extension\LinkExtension extends \Twig_Extension which is deprecated since Twig 2.7. It should use Twig\Extension\AbstractExtension instead.

This makes the current version of Hateoas incompatible with Symfony 4.4.
@goetas
Copy link
Collaborator

goetas commented Nov 22, 2019 •
edited
Loading

Thanks for the report.

It is true.

I'm happy to accept a pull request that fixes the the issue.

@W0rma W0rma mentioned this issue Nov 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix twig deprecations
2 participants
@Vorta @goetas