Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide options for when Wezterm/kitty windows should nest #56

Closed
ttytm opened this issue Jul 21, 2023 · 7 comments · Fixed by #62
Closed

Provide options for when Wezterm/kitty windows should nest #56

ttytm opened this issue Jul 21, 2023 · 7 comments · Fixed by #62
Assignees
Labels
enhancement New feature or request

Comments

@ttytm
Copy link

ttytm commented Jul 21, 2023

Describe the bug

Currently, I'm pinning commit = "d92c93959e9ac52a00002d6fd64c2d2ca5dd7192", since one of the changes afterwards includes a regression that will close a neovim instance when trying to open nvim in another tab of a terminal that already has a running nvim instance. It would be necessary to open another terminal and run it to not have it closed.
A fix would be superb - here and then there always comes up a use-case for terminal tabs :).

System

  • Linux, deb based
  • Neovim Nightly
  • Tested with kitty and wezterm tabs.
@ttytm ttytm added the bug Something isn't working label Jul 21, 2023
@willothy
Copy link
Owner

I'm not sure I understand what you're describing, could you provide a list of repro steps and/or a video? I'll look into it asap once I have some more info. Thanks for reporting :)

@ttytm
Copy link
Author

ttytm commented Jul 21, 2023

Sequence.1.mp4

Hopefully this makes it clear, else please let me know @willothy .
It shows: opeining nvim in a new kitty terminal without issues. Then I'm trying to do it in another tab but it immediately closes on me, trying this multiple times. Same for wezterm.


It doesn't happen with the mentioned commit.

I will bisect and add the exact commit for better analysis.

@ttytm
Copy link
Author

ttytm commented Jul 21, 2023

Ahh, I see

	one_per = {
		kitty = true, -- Flatten all instance in the current Kitty session
		wezterm = true, -- Flatten all instance in the current Wezterm session
	},

was added.

Didn't notice this as breaking change or opt-in feature. Had to manually opt out of it.

@willothy
Copy link
Owner

willothy commented Jul 21, 2023

Ah, yes I should've marked it as breaking. That's my bad, I was perhaps a bit too hasty merging that. But with that being said, ideally you'd still be able to open a new session in another window. I'm not a fan of not being able to have multiple nvim windows open, even though I like to be able to open things from other Wezterm windows sometimes, so I'll try to get this fixed in the next few days by adding some options for when wezterm/kitty windows nest. Until then, disabling the features should be good :)

@ttytm
Copy link
Author

ttytm commented Jul 21, 2023

All good, sorry for the trouble and thanks for the support!

@ttytm ttytm closed this as completed Jul 21, 2023
@willothy
Copy link
Owner

Actually I'd like to leave this open until I have a PR adding some more options, just as a sort of to-do :)

@willothy willothy reopened this Jul 21, 2023
@willothy willothy changed the title Regression: flatten won't allow to work with tabs in multiplexer like kitty or wezterm Provide options for when Wezterm/kitty windows should nest Jul 21, 2023
@willothy willothy added enhancement New feature or request and removed bug Something isn't working labels Jul 21, 2023
@willothy
Copy link
Owner

For now you should be able to customize the pipe_path function to suit your needs. Returning nil from that will allow the instance to open. Other than that, what options would be helpful? I'm not quite sure what to add for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants