-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Angular 1.4/1.5 #88
Comments
Related to #86. |
One bug with 1.5 is that the split view adds ="true" on the win-pivot. Angular 1.5 supports named transcludes, so it looks for an element named "true". ng-transclude should not set to true, only add the attribute without content.
|
Hi, Thank you |
With introduction of AngularJS 1.5.x transclusion was changed to support the long awaited multi-transcludes. Since ListView adds transclude=true, Angular is looking for the transclude slot named "true". See @sondreb explanation. So you should use a version < 1.5.x. I'm using 1.4.8 and everything works fine. |
I just froze a copy of angular-winjs.js and did a search and replace: Seems to work fine. |
@albatrosary thanks for the question! It's been answered here: winjs/winjs#1622 (comment) |
@humale thank you! Take a look at. |
Hi.
Now Angular version is 1.3, do you have any plans to 1.4 / 1.5?
It is an error if run in 1.5.
I want you to the version up.
Thank you.
The text was updated successfully, but these errors were encountered: