Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Angular 1.4/1.5 #88

Closed
albatrosary opened this issue Dec 2, 2015 · 7 comments
Closed

Support for Angular 1.4/1.5 #88

albatrosary opened this issue Dec 2, 2015 · 7 comments

Comments

@albatrosary
Copy link

Hi.

Now Angular version is 1.3, do you have any plans to 1.4 / 1.5?
It is an error if run in 1.5.
I want you to the version up.

Thank you.

@jdalton jdalton added this to the Future milestone Dec 5, 2015
@jdalton
Copy link
Contributor

jdalton commented Dec 5, 2015

Related to #86.

@sondreb
Copy link
Contributor

sondreb commented Jan 4, 2016

One bug with 1.5 is that the split view adds ="true" on the win-pivot. Angular 1.5 supports named transcludes, so it looks for an element named "true". ng-transclude should not set to true, only add the attribute without content.

Error: [$compile:noslot] No parent directive that requires a transclusion with slot name "true". Element: <div ng-transclude="true"

@AndreasM009
Copy link

Hi,
I currently updated my application to AngularJS 1.5.3.
It seems that the WinJS ListView does not work with AngularJS 1.5.3.
I get the following error when Angular tries to compile win-list-view directive:
Error: [$compile:noslot] http://errors.angularjs.org/1.5.3/$compile/noslot? ....
Any ideas?

Thank you

@DimiGrigoriadis
Copy link

With introduction of AngularJS 1.5.x transclusion was changed to support the long awaited multi-transcludes. Since ListView adds transclude=true, Angular is looking for the transclude slot named "true". See @sondreb explanation. So you should use a version < 1.5.x. I'm using 1.4.8 and everything works fine.

@sensiblearts
Copy link

I just froze a copy of angular-winjs.js and did a search and replace:
// replaced: ng-transclude='true'
// with: ng-transclude

Seems to work fine.

@humale
Copy link

humale commented Apr 22, 2016

@albatrosary thanks for the question! It's been answered here: winjs/winjs#1622 (comment)

@humale humale closed this as completed Apr 22, 2016
@albatrosary
Copy link
Author

@humale thank you! Take a look at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants