Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop colors in favor of other modules? #458

Closed
indexzero opened this issue Sep 23, 2014 · 7 comments
Closed

Drop colors in favor of other modules? #458

indexzero opened this issue Sep 23, 2014 · 7 comments

Comments

@indexzero
Copy link
Member

@sindresorhus had a very interesting approach we could explore in this comment: #402 (comment)

@genediazjr
Copy link

👍 I aggree with @sindresorhus on using supports-color and ansi-styles

@3rd-Eden
Copy link
Contributor

You would only use colors in development environments. So the performance impact can be neglected here.

@genediazjr
Copy link

But don't you think it would cause a problem?

@jbnicolai
Copy link

@indexzero would a PR making this change be accepted?

See #400 and #402 for further discussion.

@indexzero
Copy link
Member Author

@jbnicolai absolutely. Would love to see some new approaches to coloring.

@lufzle
Copy link

lufzle commented Jul 14, 2015

+1

@indexzero
Copy link
Member Author

After the work by @DABH to upgrade colors itself closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants