-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop colors in favor of other modules? #458
Comments
👍 I aggree with @sindresorhus on using supports-color and ansi-styles |
You would only use colors in development environments. So the performance impact can be neglected here. |
But don't you think it would cause a problem? |
@indexzero would a PR making this change be accepted? |
@jbnicolai absolutely. Would love to see some new approaches to coloring. |
+1 |
After the work by @DABH to upgrade colors itself closing this issue. |
@sindresorhus had a very interesting approach we could explore in this comment: #402 (comment)
The text was updated successfully, but these errors were encountered: