Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated output images (all formats) width and height #299

Closed
tobiokanobi opened this issue Dec 12, 2022 · 8 comments
Closed

Generated output images (all formats) width and height #299

tobiokanobi opened this issue Dec 12, 2022 · 8 comments
Labels
duplicate This issue or pull request already exists

Comments

@tobiokanobi
Copy link

Great piece of work! (But) When using it under Windows Subsystem for Linux (WSL), the generated output files seem to have width and height reversed?

Attached to images, the first is the tutorial01, unchanged, the second is a copy and new created image (tobi_1).

tutorial01
tobi_1

Kind regards,

Tobias

@tobiokanobi
Copy link
Author

I just tested it a pure Ubunto environment, looks identical to generated in the WSL Ubunto envrionment.

@kvid
Copy link
Collaborator

kvid commented Dec 12, 2022

Which release or branch of WireViz are you using? This should not happen with the latest release.

This seems to be a duplicate of #258 that was fixed by PR #261 and then merged into master in v0.3.2, but not currently included in dev, latest, or any of the PR branches. If you need this fix together with such a branch, then I suggest you create your own local branch from the dev or PR branch and cherry-pick the fix 9af0cb8 on top of it.

@tobiokanobi
Copy link
Author

The branch seems to be *dev ; the version is 0.4dev0;

I checked the code (found the missing new lines) and tried to cherry pick, but just got some funny errors after that. I may have done some idots errors, by changing just the code, saving it and then trying to run it again.

@tobiokanobi
Copy link
Author

Strange, uninstalled it, installed latest version again (pip3 install wireviz), suddenly the version is 0.3.2 and it is working :-?

@kvid
Copy link
Collaborator

kvid commented Dec 12, 2022

Maybe you have earlier cloned the git repository and installed the dev branch. Now, when you have installed the latest release, it should work without needing the cherry-pick.

@tobiokanobi
Copy link
Author

Guess you are right! Thanks for help.

@Tensdale
Copy link

I am currently also having this exact problem after cloning the current repository:

!pip3 install wireviz
!pip3 install --upgrade wireviz

The example codes gets saved like this:

my_wire_2 (1)

@tobiokanobi
Copy link
Author

Check which branch you cloned (master or dev.) . This was my problem.

@kvid kvid added the duplicate This issue or pull request already exists label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants