Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(errors): fix error messages rendering incorrectly #12942

Merged
merged 6 commits into from
Jan 10, 2025
Merged

fix(errors): fix error messages rendering incorrectly #12942

merged 6 commits into from
Jan 10, 2025
+9 −2

Conversation

liruifengv
Copy link
Member

@liruifengv liruifengv commented Jan 9, 2025 •
edited
Loading

Changes

  • fix error messages rendering incorrectly

before:
image

after:
I don't know how to test it.

Testing

Docs

This change will update docs

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: a675f15

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) docs pr labels Jan 9, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 9, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #12942 will not alter performance

Comparing liruifengv:fix-errors-data (a675f15) with main (faf74af)

Summary

✅ 6 untouched benchmarks

florian-lefebvre
florian-lefebvre reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the message is complex this will fail. I think what we want instead is provide a @message jsdoc annotation. There are examples in this file

@liruifengv
Copy link
Member Author

Because the message is complex this will fail. I think what we want instead is provide a @message jsdoc annotation. There are examples in this file

Thank you. I will take a look later.

@liruifengv
Copy link
Member Author

I have added a @message jsdoc annotation for docs. @ematipico @florian-lefebvre

@liruifengv
Copy link
Member Author

also cc @sarah11918

@ascorbic ascorbic merged commit f00c2dd into withastro:main Jan 10, 2025
16 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Jan 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-lefebvre florian-lefebvre florian-lefebvre approved these changes

@ematipico ematipico ematipico approved these changes

@ascorbic ascorbic ascorbic approved these changes

Assignees
No one assigned
Labels
docs pr pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liruifengv @ascorbic @ematipico @florian-lefebvre