Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 BUG: Hoisted scripts not working with Astro.glob in dev #3933

Closed
1 task
jeremydw opened this issue Jul 14, 2022 · 1 comment · Fixed by #3930
Closed
1 task

🐛 BUG: Hoisted scripts not working with Astro.glob in dev #3933

jeremydw opened this issue Jul 14, 2022 · 1 comment · Fixed by #3930
Assignees
@matthewp
Labels
- P5: urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority)

Comments

@jeremydw
Copy link

What version of astro are you using?

1.0.0-beta.71

Are you using an SSR adapter? If so, which one?

None

What package manager are you using?

npm

What operating system are you using?

Linux

Describe the Bug

  • The dev server is not picking up hoisted scripts when using Astro components via Astro.glob.
  • There are no issues when using astro build, the client-side hoisted scripts just don't work in dev mode.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-zrlmxo?file=src%2Fcomponents%2Fmy-component.astro,src%2Fpages%2Findex.astro

Participation

  • I am willing to submit a pull request for this issue.
@jeremydw
Copy link
Author

@matthewp has the fix for this per Discord in #3930

@natemoo-re natemoo-re added - P5: urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) s2-medium labels Jul 15, 2022
@natemoo-re natemoo-re linked a pull request Jul 15, 2022 that will close this issue
Hoist Astro.globbed hoisted scripts in dev #3930
Merged
@jeremydw jeremydw mentioned this issue Jul 20, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewp matthewp

Labels
- P5: urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hoist Astro.globbed hoisted scripts in dev withastro/astro
3 participants
@matthewp @jeremydw @natemoo-re