-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vercel adapter doesn't work with <Code /> component #6174
Comments
Thanks! It looks like this is due to the fact that shiki dynamically loads json files. I feel like we have solved this issue in the past, let me do some research and see what changed here. |
Ah yes, we did previously fix this here: #5409 |
@Ehesp the reproduction doesn't seem to use Code, or vercel. Can you update it? |
Oh woops I pushed the empty repo. Updated now |
Just dropping in to say I can recreate the error. Digging into why our solution isn't working any more. |
Pretty sure it's caused by this change: #5952 Working on a fix. |
Should be fixed by #6198 Going to deploy a test app to confirm. |
Fix is working: https://astro-vercel-shiki-error-kljl7rwie-matthew6.vercel.app/ |
Being released now, thanks again for bringing this important issue to our attention @Ehesp https://github.com/withastro/astro/actions/runs/4137734219/jobs/7153272973 |
@matthewp thanks, although I've just upgraded both
It's a bit late here though so I'll properly check it out in the morning. |
I have got the same error today when using
|
What version of
astro
are you using?2.0.8
Are you using an SSR adapter? If so, which one?
Vercel (^3.0.1)
What package manager are you using?
npm
What operating system are you using?
Mac
Describe the Bug
When including the
<Code />
component in pages, the shiki themes are not being uploaded to Vercel:See repro link for an example. This works in dev, but fails when deployed to Vercel.
Link to Minimal Reproducible Example
https://github.com/Ehesp/astro-vercel-shiki-error
Participation
The text was updated successfully, but these errors were encountered: