If you nest two Solid islands into each other, the nested one is mounted twice

[alexander-lozovsky]

What version of astro are you using?

2.0.12

Are you using an SSR adapter? If so, which one?

No

What package manager are you using?

npm

What operating system are you using?

Mac

Describe the Bug

When you render two Solid islands nested into each other, the nested one is mounted twice.

So in case you have something like this:

<Wrapper client:idle>
  <NestedComponent client:idle>
    <p>Hello world</p>
  </NestedComponent>
</Wrapper>

NestedComponent runs twice in the browser, which means that if you run some logic inside onMount, it runs twice.

See the attached stackblitz: click "Open in New Tab" and observe "NestedComponent" logged twice in the console

Same composition with React components works as expected https://stackblitz.com/edit/github-tgt7ck?file=src/pages/index.astro

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-gcp42c?file=package.json

Participation

• I am willing to submit a pull request for this issue.

[idiglove]

I don't see "Nested Component" being logged twice

[alexander-lozovsky]

@idiglove you're looking at the dev server logs, please check the browser logs

[SerekKiri]

Problem might be with a fallback to load event from requestIdleCallback as that what astro does -> https://docs.astro.build/en/reference/directives-reference/#clientidle

window.requestIdleCallback is not supported on safari

Question though as there is no load being used but a setTimeout instead if I'm looking into proper places.

I might dig a bit 🤔

[SerekKiri]

Also docs update for client:idle was 10 months ago and 8 months ago for requestIdleCallback so probably docs should be updated as well 👍🏼

[SerekKiri]

@alexander-lozovsky did you test that in a production mode?

[alexander-lozovsky]

@SerekKiri yes, it happens in both SSR and SSG builds

[SerekKiri]

@alexander-lozovsky could you check if your project will work properly with changes added by @matthewp in the PR mentioned above?

[bluwy]

I haven't tested yet, but #7370 might also help with this.

[bluwy]

I ran the repro and updated Astro to latest and it seems to be fixed now.