Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pagefind data attribute #2740

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Fix pagefind data attribute #2740

merged 1 commit into from
Jan 6, 2025

Conversation

HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented Dec 24, 2024

Description

This PR fixes an issue preventing to disable Pagefind using the pagefind frontmatter field.

With the Astro 5 change to non-boolean HTML attribute values, disabling pagefind using the pagefind frontmatter field would render data-pagefind-body="false" in the HTML instead of omitting the attribute entirely.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 24, 2024

🦋 Changeset detected

Latest commit: 651702d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Dec 24, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 24, 2024 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 651702d
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/676a773c6aaa2c0008a9794c
😎 Deploy Preview https://deploy-preview-2740--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@HiDeoo HiDeoo mentioned this pull request Dec 24, 2024
Closed
1 task
delucis
delucis approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Great catch — I knew those boolean attributes were going to be tricky to track down everywhere.

@delucis delucis added the 🌟 patch Change that triggers a patch release label Jan 6, 2025
@delucis delucis merged commit 0e169c9 into withastro:main Jan 6, 2025
16 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Jan 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pagefind false does not work on index page
2 participants
@HiDeoo @delucis