Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config for disabling the auto snapshot before the test #13

Open
hepiyellow opened this issue Mar 7, 2018 · 0 comments
Open

Add config for disabling the auto snapshot before the test #13

hepiyellow opened this issue Mar 7, 2018 · 0 comments

Comments

@hepiyellow
Copy link
Contributor

The problem

In wix-style-react with use an autoExample (and driver).
The auto example renders a default component to the page.
It renders the same component with the same props every time the page is loaded.
Then, in each e2e test we set the props remotely (it re-renders the component).
And we can assert (expect) on whatever, and have a 'end' snapshot.

The 'before' snapshots will all look the same.
So it is redundant, and creates redundant review work with applitools.

Solution

I thought to add a config to eyes, something like:

{
  beforeSnapshotEnabled: boolean, // default true
  afterSnapshotEnabled: boolean // default true
}

This config will be global (since eyes.it exports a singleton of eyes),
and in order to make the config temporary (local to an it or describe), we'll need to use before and after to apply/revert a config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant