Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pleb doesn't support monorepos with nested package structure #505

Open
RomanYar opened this issue Nov 8, 2022 · 4 comments
Open

pleb doesn't support monorepos with nested package structure #505

RomanYar opened this issue Nov 8, 2022 · 4 comments

Comments

@RomanYar
Copy link

RomanYar commented Nov 8, 2022

We tried implementing pleb for publishing our packages, and we saw that in our structure, which is not a flat packages structure, pleb fails locating the packages.

steps to reproduce:

git clone [email protected]:wixplosives/sample-monorepo.git ./test-pleb
cd test-pleb
# now we need to change the root package.json's workspaces field to "packages/**/*".
# after done that: 
rm -rf packages
mkdir -p packages/test/test-package
cd packages/test/test-package
npm init -y
echo "console.log('hello world')">index.js

# this will locate that the package was never published
npx pleb publish --dry-run
cd ../../../

# this will not find the package
npx pleb publish --dry-run
@AviVahl
Copy link
Contributor

AviVahl commented Nov 8, 2022

Need to update the workspaces field in root package.json?

@RomanYar
Copy link
Author

RomanYar commented Nov 8, 2022

no sure it's a mandatory step, I am not sure on how pleb locates the packages in the repo

@AviVahl
Copy link
Contributor

AviVahl commented Nov 8, 2022

It looks the packages up using the "workspaces" field, just like npm or yarn would. It needs to point to the packages.

@AviVahl
Copy link
Contributor

AviVahl commented Nov 8, 2022

oh, just noticed the comment saying packages/**/*. that worked on npm/yarn, but not pleb?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants