use qobject_cast where possible over dynamic cast

Its faster and has a compile time check for qobject
wluker · Oct 20, 2018 · c16d07c · c16d07c
1 parent 95be885
commit c16d07c
Show file tree

Hide file tree

Showing 15 changed files with 83 additions and 83 deletions.
diff --git a/AffinitySupport/AffinityZonesDock.cpp b/AffinitySupport/AffinityZonesDock.cpp
@@ -1,4 +1,4 @@
-// Copyright (c) 2014-2017 Josh Blum
+// Copyright (c) 2014-2018 Josh Blum
 // SPDX-License-Identifier: BSL-1.0
 
 #include "MainWindow/IconUtils.hpp"
@@ -88,7 +88,7 @@ QStringList AffinityZonesDock::zones(void) const
     QStringList zones;
     for (int i = 0; i < _editorsTabs->count(); i++)
     {
-        auto editor = dynamic_cast<AffinityZoneEditor *>(_editorsTabs->widget(i));
+        auto editor = qobject_cast<AffinityZoneEditor *>(_editorsTabs->widget(i));
         assert(editor != nullptr);
         zones.push_back(editor->zoneName());
     }
@@ -99,7 +99,7 @@ QColor AffinityZonesDock::zoneToColor(const QString &zone)
 {
     for (int i = 0; i < _editorsTabs->count(); i++)
     {
-        auto editor = dynamic_cast<AffinityZoneEditor *>(_editorsTabs->widget(i));
+        auto editor = qobject_cast<AffinityZoneEditor *>(_editorsTabs->widget(i));
         assert(editor != nullptr);
         if (zone == editor->zoneName()) return editor->color();
     }
@@ -110,7 +110,7 @@ QJsonObject AffinityZonesDock::zoneToConfig(const QString &zone)
 {
     for (int i = 0; i < _editorsTabs->count(); i++)
     {
-        auto editor = dynamic_cast<AffinityZoneEditor *>(_editorsTabs->widget(i));
+        auto editor = qobject_cast<AffinityZoneEditor *>(_editorsTabs->widget(i));
         assert(editor != nullptr);
         if (zone == editor->zoneName()) return editor->getCurrentConfig();
     }
@@ -198,7 +198,7 @@ void AffinityZonesDock::updateTabColors(void)
 {
     for (int i = 0; i < _editorsTabs->count(); i++)
     {
-        auto editor = dynamic_cast<AffinityZoneEditor *>(_editorsTabs->widget(i));
+        auto editor = qobject_cast<AffinityZoneEditor *>(_editorsTabs->widget(i));
         _editorsTabs->setTabIcon(i, colorToWidgetIcon(editor->color()));
     }
 }
@@ -216,7 +216,7 @@ void AffinityZonesDock::saveAffinityZoneEditorsState(void)
 
     for (int i = 0; i < _editorsTabs->count(); i++)
     {
-        auto editor = dynamic_cast<AffinityZoneEditor *>(_editorsTabs->widget(i));
+        auto editor = qobject_cast<AffinityZoneEditor *>(_editorsTabs->widget(i));
         assert(editor != nullptr);
         const auto jsonDoc = QJsonDocument(editor->getCurrentConfig());
         const auto value = jsonDoc.toJson(QJsonDocument::Compact);

diff --git a/EvalEngine/EvalEngine.cpp b/EvalEngine/EvalEngine.cpp
@@ -1,4 +1,4 @@
-// Copyright (c) 2014-2017 Josh Blum
+// Copyright (c) 2014-2018 Josh Blum
 // SPDX-License-Identifier: BSL-1.0
 
 #include "EvalEngine.hpp"
@@ -86,7 +86,7 @@ void EvalEngine::submitTopology(const GraphObjectList &graphObjects)
     BlockInfos blockInfos;
     for (auto obj : graphObjects)
     {
-        auto block = dynamic_cast<GraphBlock *>(obj);
+        auto block = qobject_cast<GraphBlock *>(obj);
         if (block == nullptr) continue;
         _blockEvalMapper->setMapping(block, block);
         connect(block, SIGNAL(triggerEvalEvent(void)), _blockEvalMapper, SLOT(map(void)));
@@ -114,7 +114,7 @@ void EvalEngine::submitActivateTopology(const bool active)
 
 void EvalEngine::submitBlock(QObject *obj)
 {
-    auto block = dynamic_cast<GraphBlock *>(obj);
+    auto block = qobject_cast<GraphBlock *>(obj);
     assert(block != nullptr);
     QMetaObject::invokeMethod(_impl, "submitBlock", Qt::QueuedConnection, Q_ARG(BlockInfo, blockToBlockInfo(block)));
 }

diff --git a/EvalEngine/TopologyTraversal.cpp b/EvalEngine/TopologyTraversal.cpp
@@ -1,4 +1,4 @@
-// Copyright (c) 2014-2017 Josh Blum
+// Copyright (c) 2014-2018 Josh Blum
 // SPDX-License-Identifier: BSL-1.0
 
 #include "TopologyEval.hpp"
@@ -23,8 +23,8 @@ static std::vector<GraphConnectionEndpoint> traverseInputEps(
     if (it != traversed.end()) return inputEndpoints;
     traversed.push_back(inputEp);
 
-    auto inputBlock = dynamic_cast<GraphBlock *>(inputEp.getObj().data());
-    auto inputBreaker = dynamic_cast<GraphBreaker *>(inputEp.getObj().data());
+    auto inputBlock = qobject_cast<GraphBlock *>(inputEp.getObj().data());
+    auto inputBreaker = qobject_cast<GraphBreaker *>(inputEp.getObj().data());
 
     if (inputBlock != nullptr)
     {
@@ -36,7 +36,7 @@ static std::vector<GraphConnectionEndpoint> traverseInputEps(
         auto nodeName = inputBreaker->getNodeName();
         for (auto graphObject : graphObjects)
         {
-            auto breaker = dynamic_cast<GraphBreaker *>(graphObject);
+            auto breaker = qobject_cast<GraphBreaker *>(graphObject);
             if (breaker == nullptr) continue;
             if (not breaker->isEnabled()) continue;
             if (breaker->getNodeName() != nodeName) continue;
@@ -45,7 +45,7 @@ static std::vector<GraphConnectionEndpoint> traverseInputEps(
             //this is the recursive part
             for (auto graphSubObject : graphObjects)
             {
-                auto connection = dynamic_cast<GraphConnection *>(graphSubObject);
+                auto connection = qobject_cast<GraphConnection *>(graphSubObject);
                 if (connection == nullptr) continue;
                 if (not connection->isEnabled()) continue;
                 if (connection->getOutputEndpoint().getObj() != breaker) continue;
@@ -69,7 +69,7 @@ ConnectionInfos TopologyEval::getConnectionInfo(const GraphObjectList &graphObje
     ConnectionInfos connections;
     for (auto graphObject : graphObjects)
     {
-        auto connection = dynamic_cast<GraphConnection *>(graphObject);
+        auto connection = qobject_cast<GraphConnection *>(graphObject);
         if (connection == nullptr) continue;
         if (not connection->isEnabled()) continue;
         if (not connection->getInputEndpoint().isValid()) continue;
@@ -81,7 +81,7 @@ ConnectionInfos TopologyEval::getConnectionInfo(const GraphObjectList &graphObje
 
             //ignore connections from output breakers
             //we will come back to them from the block to breaker to block path
-            auto outputBreaker = dynamic_cast<GraphBreaker *>(outputEp.getObj().data());
+            auto outputBreaker = qobject_cast<GraphBreaker *>(outputEp.getObj().data());
             if (outputBreaker != nullptr) continue;
 
             for (const auto &subEp : traverseInputEps(inputEp, graphObjects))

diff --git a/GraphEditor/GraphDraw.cpp b/GraphEditor/GraphDraw.cpp
@@ -1,4 +1,4 @@
-// Copyright (c) 2013-2017 Josh Blum
+// Copyright (c) 2013-2018 Josh Blum
 // SPDX-License-Identifier: BSL-1.0
 
 #include "GraphEditor/GraphDraw.hpp"
@@ -31,7 +31,7 @@
 
 GraphDraw::GraphDraw(QWidget *parent):
     QGraphicsView(parent),
-    _graphEditor(dynamic_cast<GraphEditor *>(parent)),
+    _graphEditor(qobject_cast<GraphEditor *>(parent)),
     _zoomScale(1.0),
     _selectionState(0)
 {
@@ -220,7 +220,7 @@ void GraphDraw::updateEnabledActions(void)
     //and enable/disable the actions in the move graph objects submenu
     for (auto child : mainMenu->moveGraphObjectsMenu->children())
     {
-        auto action = dynamic_cast<QAction *>(child);
+        auto action = qobject_cast<QAction *>(child);
         if (action != nullptr) action->setEnabled(selectedNoC);
     }
 }

diff --git a/GraphEditor/GraphDrawSelection.cpp b/GraphEditor/GraphDrawSelection.cpp
@@ -1,4 +1,4 @@
-// Copyright (c) 2013-2017 Josh Blum
+// Copyright (c) 2013-2018 Josh Blum
 // SPDX-License-Identifier: BSL-1.0
 
 #include "GraphEditor/GraphDraw.hpp"
@@ -243,10 +243,10 @@ GraphObjectList GraphDraw::getGraphObjects(const int selectionFlags)
     {
         auto o = dynamic_cast<GraphObject *>(child);
         if (o == nullptr) continue;
-        if (((selectionFlags & GRAPH_BLOCK) != 0) and (dynamic_cast<GraphBlock *>(o) != nullptr)) l.push_back(o);
-        if (((selectionFlags & GRAPH_BREAKER) != 0) and (dynamic_cast<GraphBreaker *>(o) != nullptr)) l.push_back(o);
-        if (((selectionFlags & GRAPH_CONNECTION) != 0) and (dynamic_cast<GraphConnection *>(o) != nullptr)) l.push_back(o);
-        if (((selectionFlags & GRAPH_WIDGET) != 0) and (dynamic_cast<GraphWidget *>(o) != nullptr)) l.push_back(o);
+        if (((selectionFlags & GRAPH_BLOCK) != 0) and (qobject_cast<GraphBlock *>(o) != nullptr)) l.push_back(o);
+        if (((selectionFlags & GRAPH_BREAKER) != 0) and (qobject_cast<GraphBreaker *>(o) != nullptr)) l.push_back(o);
+        if (((selectionFlags & GRAPH_CONNECTION) != 0) and (qobject_cast<GraphConnection *>(o) != nullptr)) l.push_back(o);
+        if (((selectionFlags & GRAPH_WIDGET) != 0) and (qobject_cast<GraphWidget *>(o) != nullptr)) l.push_back(o);
     }
     return l;
 }
@@ -339,7 +339,7 @@ QString GraphDraw::getSelectionDescription(const int selectionFlags)
     //if a single connection is selected, pretty print its endpoint IDs
     if (selected.size() == 1)
     {
-        auto conn = dynamic_cast<GraphConnection *>(selected.at(0));
+        auto conn = qobject_cast<GraphConnection *>(selected.at(0));
         if (conn == nullptr) return selected.at(0)->getId();
         return tr("%1[%2] to %3[%4]").arg(
             conn->getOutputEndpoint().getObj()->getId(),

diff --git a/GraphEditor/GraphEditor.cpp b/GraphEditor/GraphEditor.cpp
@@ -45,7 +45,7 @@ static const size_t POLL_WIDGET_CHANGES_MS = 1000;
 GraphEditor::GraphEditor(QWidget *parent):
     QTabWidget(parent),
     _logger(Poco::Logger::get("PothosFlow.GraphEditor")),
-    _parentTabWidget(dynamic_cast<QTabWidget *>(parent)),
+    _parentTabWidget(qobject_cast<QTabWidget *>(parent)),
     _moveGraphObjectsMapper(new QSignalMapper(this)),
     _insertGraphWidgetsMapper(new QSignalMapper(this)),
     _stateManager(new GraphStateManager(this)),
@@ -281,7 +281,7 @@ GraphConnection *GraphEditor::makeConnection(const GraphConnectionEndpoint &ep0,
     //duplicate check
     for (auto obj : this->getGraphObjects(GRAPH_CONNECTION))
     {
-        auto conn = dynamic_cast<GraphConnection *>(obj);
+        auto conn = qobject_cast<GraphConnection *>(obj);
         assert(conn != nullptr);
         if (
             (conn->getOutputEndpoint() == ep0 and conn->getInputEndpoint() == ep1) or
@@ -312,7 +312,7 @@ static GraphBreaker *findInputBreaker(GraphEditor *editor, const GraphConnection
 {
     for (auto obj : editor->getGraphObjects(GRAPH_CONNECTION))
     {
-        auto conn = dynamic_cast<GraphConnection *>(obj);
+        auto conn = qobject_cast<GraphConnection *>(obj);
         assert(conn != nullptr);
         if (not (conn->getOutputEndpoint().getObj()->scene() == conn->getInputEndpoint().getObj()->scene())) continue;
         if (not (conn->getOutputEndpoint() == ep)) continue;
@@ -321,7 +321,7 @@ static GraphBreaker *findInputBreaker(GraphEditor *editor, const GraphConnection
             const auto &pairs = conn->getSigSlotPairs();
             if (not pairs.empty() and pairs.at(0).first != signalName) continue;
         }
-        auto breaker = dynamic_cast<GraphBreaker *>(conn->getInputEndpoint().getObj().data());
+        auto breaker = qobject_cast<GraphBreaker *>(conn->getInputEndpoint().getObj().data());
         if (breaker == nullptr) continue;
         return breaker;
     }
@@ -346,7 +346,7 @@ void GraphEditor::handleMoveGraphObjects(const int index)
     std::vector<GraphConnection *> boundaryConnections;
     for (auto obj : this->getGraphObjects(GRAPH_CONNECTION))
     {
-        auto conn = dynamic_cast<GraphConnection *>(obj);
+        auto conn = qobject_cast<GraphConnection *>(obj);
         assert(conn != nullptr);
 
         //Connection has the same endpoints, so make sure that the parent is corrected to the endpoint
@@ -414,7 +414,7 @@ void GraphEditor::handleMoveGraphObjects(const int index)
             for (auto obj : this->getGraphObjects(GRAPH_BREAKER))
             {
                 if (obj->draw() != epIn.getObj()->draw()) continue;
-                auto outBreaker = dynamic_cast<GraphBreaker *>(obj);
+                auto outBreaker = qobject_cast<GraphBreaker *>(obj);
                 assert(outBreaker != nullptr);
                 if (outBreaker->isInput()) continue;
                 if (outBreaker->getNodeName() != name) continue;
@@ -451,7 +451,7 @@ void GraphEditor::handleAddBlock(const QJsonObject &blockDesc)
     QPointF where(std::rand()%100, std::rand()%100);
 
     //determine where, a nice point on the visible drawing area sort of upper left
-    auto view = dynamic_cast<QGraphicsView *>(this->currentWidget());
+    auto view = qobject_cast<QGraphicsView *>(this->currentWidget());
     where += view->mapToScene(this->size().width()/4, this->size().height()/4);
 
     this->handleAddBlock(blockDesc, where);
@@ -515,7 +515,7 @@ void GraphEditor::handleCreateOutputBreaker(void)
 
 void GraphEditor::handleInsertGraphWidget(QObject *obj)
 {
-    auto block = dynamic_cast<GraphBlock *>(obj);
+    auto block = qobject_cast<GraphBlock *>(obj);
     assert(block != nullptr);
     assert(block->isGraphWidget());
 
@@ -667,7 +667,7 @@ void GraphEditor::handlePaste(void)
     }
 
     //determine an acceptable position to center the paste
-    auto view = dynamic_cast<QGraphicsView *>(this->currentWidget());
+    auto view = qobject_cast<QGraphicsView *>(this->currentWidget());
     auto pastePos = view->mapToScene(view->mapFromGlobal(QCursor::pos()));
     if (not view->sceneRect().contains(pastePos))
     {
@@ -833,7 +833,7 @@ void GraphEditor::handleSetEnabled(const bool enb)
     for (auto obj : draw->getObjectsSelected())
     {
         //stash the graph widget's actual block
-        auto graphWidget = dynamic_cast<GraphWidget *>(obj);
+        auto graphWidget = qobject_cast<GraphWidget *>(obj);
         if (graphWidget != nullptr) obj = graphWidget->getGraphBlock();
         if (obj->isEnabled() != enb) objs.insert(obj);
     }
@@ -887,7 +887,7 @@ void GraphEditor::handleAffinityZoneClicked(const QString &zone)
 
     for (auto obj : draw->getObjectsSelected(GRAPH_BLOCK))
     {
-        auto block = dynamic_cast<GraphBlock *>(obj);
+        auto block = qobject_cast<GraphBlock *>(obj);
         assert(block != nullptr);
         block->setAffinityZone(zone);
     }
@@ -898,7 +898,7 @@ void GraphEditor::handleAffinityZoneChanged(const QString &zone)
 {
     for (auto obj : this->getGraphObjects(GRAPH_BLOCK))
     {
-        auto block = dynamic_cast<GraphBlock *>(obj);
+        auto block = qobject_cast<GraphBlock *>(obj);
         assert(block != nullptr);
         if (block->getAffinityZone() == zone) block->changed();
     }
@@ -938,7 +938,7 @@ void GraphEditor::handleBlockDisplayModeChange(void)
 {
     for (auto obj : this->getGraphObjects(GRAPH_BLOCK))
     {
-        auto block = dynamic_cast<GraphBlock *>(obj);
+        auto block = qobject_cast<GraphBlock *>(obj);
         assert(block != nullptr);
         block->changed();
     }
@@ -962,7 +962,7 @@ void GraphEditor::handleBlockXcrement(const int adj)
     GraphObjectList changedObjects;
     for (auto obj : draw->getObjectsSelected(GRAPH_BLOCK))
     {
-        auto block = dynamic_cast<GraphBlock *>(obj);
+        auto block = qobject_cast<GraphBlock *>(obj);
         assert(block != nullptr);
         for (const auto &propKey : block->getProperties())
         {
@@ -1096,14 +1096,14 @@ void GraphEditor::updateGraphEditorMenus(void)
     bool hasGraphWidgetsToInsert = false;
     for (auto obj : this->getGraphObjects(GRAPH_BLOCK))
     {
-        auto block = dynamic_cast<GraphBlock *>(obj);
+        auto block = qobject_cast<GraphBlock *>(obj);
         assert(block != nullptr);
         if (not block->isGraphWidget()) continue;
 
         //does block have an active graph display?
         for (auto subObj : this->getGraphObjects(GRAPH_WIDGET))
         {
-            auto display = dynamic_cast<GraphWidget *>(subObj);
+            auto display = qobject_cast<GraphWidget *>(subObj);
             assert(display != nullptr);
             if (display->getGraphBlock() == block) goto next_block;
         }
@@ -1123,7 +1123,7 @@ void GraphEditor::updateGraphEditorMenus(void)
 
 GraphDraw *GraphEditor::getGraphDraw(const int index) const
 {
-    auto draw = dynamic_cast<GraphDraw *>(this->widget(index));
+    auto draw = qobject_cast<GraphDraw *>(this->widget(index));
     assert(draw != nullptr);
     return draw;
 }
@@ -1201,7 +1201,7 @@ void GraphEditor::handlePollWidgetTimer(void)
     QStringList changedIds;
     for (auto obj : this->getGraphObjects(GRAPH_WIDGET))
     {
-        auto graphWidget = dynamic_cast<const GraphWidget *>(obj);
+        auto graphWidget = qobject_cast<const GraphWidget *>(obj);
         assert(graphWidget != nullptr);
         if (not graphWidget->didWidgetStateChange()) continue;
         auto graphBlock = graphWidget->getGraphBlock();

diff --git a/GraphEditor/GraphEditorExport.cpp b/GraphEditor/GraphEditorExport.cpp
@@ -1,4 +1,4 @@
-// Copyright (c) 2016-2017 Josh Blum
+// Copyright (c) 2016-2018 Josh Blum
 // SPDX-License-Identifier: BSL-1.0
 
 #include "GraphEditor/GraphEditor.hpp"
@@ -66,7 +66,7 @@ void GraphEditor::exportToJSONTopology(const QString &fileName)
     std::map<size_t, const GraphBlock*> uidToBlock;
     for (const auto *obj : graphObjects)
     {
-        const auto block = dynamic_cast<const GraphBlock *>(obj);
+        const auto block = qobject_cast<const GraphBlock *>(obj);
         if (block == nullptr) continue;
         if (not block->isEnabled()) continue;
         if (block->isGraphWidget()) continue;