Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional FTP setup #297

Closed
4 tasks
tomkralidis opened this issue Oct 19, 2022 · 8 comments
Closed
4 tasks

add optional FTP setup #297

tomkralidis opened this issue Oct 19, 2022 · 8 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@tomkralidis
Copy link
Collaborator

User story

As a wis2box user, I want wis2box to be able to accept data upload via FTP, so that I can upload my data in a lower barrier fashion.

Acceptance criteria

  • optional docker setup for FTP (ProFTPD)

Definition of done

  • unit/functional tests added/updated
  • documentation updated
  • live demonstration provided
@tomkralidis tomkralidis added the enhancement New feature or request label Oct 19, 2022
@tomkralidis tomkralidis added this to the sprint-008 milestone Nov 14, 2022
@maaikelimper
Copy link
Collaborator

I've added a separate repository for this feature here: https://github.com/wmo-im/minio-ftp-forwarder

I've tested this on the physical wis2box WMO has started to prepare for Zimbabwe

@maaikelimper
Copy link
Collaborator

add the option of using 'minio-ftp-forwarder' to our documentation describing data ingestion options

@tomkralidis
Copy link
Collaborator Author

@maaikelimper to add optional docker compose setup in docker/

@maaikelimper
Copy link
Collaborator

I need to do some more work to test and prepare standalone images and a docker-compose that reference environment variables from wis2box, to be bumped to sprint-009

@maaikelimper
Copy link
Collaborator

I've prepared the image for wis2box-ftp which is now available as ghcr.io/wmo-im/wis2box-ftp published through GHA from https://github.com/wmo-im/wis2box-ftp

I'm wondering how to add this as an option to wis2box, I could introduce another flag '--ftp' so a user could start wis2box with:
python3 wis2box-ctl.py --ftp start
similar to the '--ssl' option I introduced in 'SSL everywhere'.

@tomkralidis , I'm not sure you agree with this way of adding services to the wis2box-docker-compose-stack. Do you have other ideas how you would like to organize this?

@tomkralidis
Copy link
Collaborator Author

As an extra, I think we should document this in wis2box for optional FTP forwarding workflows, with steps on how to run wis2box-ftp. I don't think this needs to be supported by wis2box-ctl.py proper.

@tomkralidis
Copy link
Collaborator Author

Implemented in #409

@tomkralidis
Copy link
Collaborator Author

To test in a future iteration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants