Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reason when Desktop.fetch rejects with timeout #54

Closed
calebl opened this issue Jan 12, 2017 · 3 comments
Closed

Add reason when Desktop.fetch rejects with timeout #54

calebl opened this issue Jan 12, 2017 · 3 comments
Labels
backlog feature request

Comments

@calebl
Copy link

calebl commented Jan 12, 2017

Currently reject() is called (line 210 of preload.js) without a reason given which logs as a Promise rejected for an undefined reason. Took me awhile to figure out that my fetches were timing out.
@wojtkowiak
Copy link
Owner

Can it just reject to timeout string or would you like to specify the value of timeout rejection?

@calebl
Copy link
Author

calebl commented Jan 13, 2017

Just timeout makes sense to me. Or maybe the name of the module and the event and timeout.

@wojtkowiak
Copy link
Owner

Forgot to notice you. This is in place for some time now
https://github.com/wojtkowiak/meteor-desktop/blob/master/skeleton/preload.js#L210

@wojtkowiak wojtkowiak mentioned this issue May 8, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@calebl @wojtkowiak