Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💅 Drop WC < 6.0 workaround from full-content layout #1311

Closed
tomalec opened this issue Mar 10, 2022 · 1 comment · Fixed by #1493
Closed

💅 Drop WC < 6.0 workaround from full-content layout #1311

tomalec opened this issue Mar 10, 2022 · 1 comment · Fixed by #1493
Assignees
@eason9487
Labels
good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: technical debt This issue/PR represents/solves the technical debt of the project.

Comments

@tomalec
Copy link
Member

tomalec commented Mar 10, 2022

GLA is now compatible with WC 6.3, according to our team tests.

Describe the issue:

  1. The WC tested up to was not updated https://github.com/woocommerce/google-listings-and-ads/blob/develop/google-listings-and-ads.php#L15
  2. The workaround introduced in https://github.com/woocommerce/google-listings-and-ads/pull/1206/files#diff-1b8407a0e185b837137891f362cd7c3b2e8d553b388a6e4ea73cd11f38de3d45R2-R14 is no longer needed if we also bump WC requires at least: 5.8 according to L-2

Steps to reproduce:

  1. Open https://github.com/woocommerce/google-listings-and-ads/blob/develop/js/src/css/shared/_woocommerce-admin.scss#L1-L14
  2. Check for any no longer needed code :)
  3. Thank @eason9487 for making nicely-documented code 🙏

Expected behavior:

There amount of legacy code is minimal

Actual behavior:

there is one rule that most probably is no longer needed

Additional details:
@tomalec tomalec added good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. type: technical debt This issue/PR represents/solves the technical debt of the project. priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. labels Mar 10, 2022
@mikkamp
Copy link
Contributor

mikkamp commented Mar 11, 2022

Just linking a related issue which can be unblocked if we bump the minimum WC version: #1048

@eason9487 eason9487 self-assigned this May 9, 2022
@eason9487 eason9487 mentioned this issue May 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eason9487 eason9487

Labels
good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: technical debt This issue/PR represents/solves the technical debt of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop support for WooCommerce < 6.0 and clean up workarounds woocommerce/google-listings-and-ads
3 participants
@tomalec @mikkamp @eason9487