Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The maximum value of the shipping time range is not correctly synced to Google Merchant Center #2759

Closed
eason9487 opened this issue Jan 10, 2025 · 1 comment · Fixed by #2760
Closed

The maximum value of the shipping time range is not correctly synced to Google Merchant Center #2759

eason9487 opened this issue Jan 10, 2025 · 1 comment · Fixed by #2760
Assignees
@mikkamp
Labels
merchant center priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: bug The issue is a confirmed bug.

Comments

@eason9487
Copy link
Member

Describe the bug:

The maximum value of the shipping time range is not correctly synced to Google Merchant Center.

Steps to reproduce:

  1. Go to shipping settings
  2. Set the maximum value for a shipping time and save changes
    Image
  3. Go to Google Merchant Center
  4. View the corresponding shipping time range in the Shipping and returns page
    Image

Expected behavior:

The max value of shipping time range is synced to Google Merchant Center.

Actual behavior:

The max value of shipping time range is incorrectly synced to Google Merchant Center with the min value.

Additional details:

This seems to be an implementation that was missed during the Shipping improvement - Phase 1 (pcTzPl-2qP-p2).
@eason9487 eason9487 self-assigned this Jan 10, 2025
@eason9487 eason9487 added type: bug The issue is a confirmed bug. merchant center priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. labels Jan 10, 2025
@mikkamp
Copy link
Contributor

mikkamp commented Jan 10, 2025

Thanks for discovering this, it should be adjusted here: https://github.com/woocommerce/google-listings-and-ads/blob/2.9.4/src/Shipping/GoogleAdapter/AbstractShippingSettingsAdapter.php#L70

Looking through the PR's that were implemented it looks like that got missed before the project handover. We should definitely get that fixed as a high priority.

@mikkamp mikkamp mentioned this issue Jan 10, 2025
Merged
@eason9487 eason9487 assigned mikkamp and unassigned eason9487 Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikkamp mikkamp

Labels
merchant center priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sync shipping max times to Google Merchant Center woocommerce/google-listings-and-ads
2 participants
@mikkamp @eason9487