-
Notifications
You must be signed in to change notification settings - Fork 221
Links for all filter blocks (reset and clear all) #7118
Comments
Hello @vivialice 👋 , Font weight & font sizeBy default, the font weight and font size seem to be different between the Active Filters and Filters by Attribute block (by Size, by Price, etc) which leaves us with 2 possible scenarios 1. Active Filters block - Clear All linkThe attributes for the Clear All link are the following:
2. Filter by Attribute block - Reset linkThe attributes for the Reset link are the following:
Hover styleFor the hover attribute, there are 3 possible scenarios: 1. Active Filters block - Clear All linkThere is no style change when we hover over the Clear All link.
2. Filter by Attribute block - Reset linkAs for the Filter by Attribute block, when we hover over the Reset button, the underline appears and the text color changes (from
3. Other links in the siteFor other links on the site like the Product Title, the behavior is almost the opposite of the Filter by Attribute block. By default, it's underlined and when hovered the underline disappears. The text color does not change.
Do you know if there is any pattern already defined that we can follow and use for components with links? cc: @albarin @tjcafferkey |
Hey @thealexandrelara 👋 Thanks for conducting this review. I'll answer your queries below: 1. 2. Other links in the site
There isn't one specifically defined for WooCommerce but in this case we should continue to follow best-practices:
|
Another thing that I'd like to discuss with you is about the Clear all because it is using a font weight Thank you for your guidance, so I'll set all links to be underlined and with 12px by default, when the user hovers over the link I'll hide the underline while maintaining the same color. |
It shouldn't be bold 👍 |
Can we ensure all links are displayed as underlined for consistency between the blocks and other areas of the site.
The text was updated successfully, but these errors were encountered: