Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECE] Integrate express payments buttonAttributes API from the Checkout Block #3590

Open
Tracked by #3381
Mayisha opened this issue Nov 6, 2024 · 0 comments
Open
Tracked by #3381
Labels
component: ECE Issues related to Express Checkout Element status: blocked The issue is blocked from progressing, waiting for another piece of work to be done.

Comments

@Mayisha
Copy link
Contributor

Mayisha commented Nov 6, 2024

Use the buttonAttributes API introduced in Woo Core in woocommerce/woocommerce#47899. This should respect the new height and borderRadius controls on the express checkout block, overriding extension settings when these are available. It should also use the darkMode setting to override the button theme.

This means the Stripe plugin specific settings will still be applied if we're not in a checkout block context. But if we are, the button sizes and colors will be synced across all express payment buttons integrated with this API.

Notes

@Mayisha Mayisha added the status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. label Nov 6, 2024
@wjrosa wjrosa self-assigned this Nov 6, 2024
@Mayisha Mayisha added the component: ECE Issues related to Express Checkout Element label Nov 18, 2024
@wjrosa wjrosa removed their assignment Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ECE Issues related to Express Checkout Element status: blocked The issue is blocked from progressing, waiting for another piece of work to be done.
Projects
None yet
Development

No branches or pull requests

2 participants