Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program ID filter for changes broken #103

Open
SvenDowideit opened this issue May 4, 2022 · 3 comments
Open

Program ID filter for changes broken #103

SvenDowideit opened this issue May 4, 2022 · 3 comments
Assignees
Labels
bug Something isn't working needs-test Needs someone to confirm if this is still an issue
Milestone

Comments

@SvenDowideit
Copy link
Member

transfer from #98

@SvenDowideit SvenDowideit added the bug Something isn't working label May 4, 2022
@SvenDowideit SvenDowideit added this to the 0.3.0 milestone May 4, 2022
@SvenDowideit SvenDowideit mentioned this issue May 4, 2022
5 tasks
@SvenDowideit
Copy link
Member Author

@nathanleclaire it seems to me that the program filter is working - though only for the accounts list, and not for the logview - as that's doing its own thing.

what did you mean by this TODO?

@nathanleclaire
Copy link
Contributor

o rly... that's news to me ... i thought it was broken, will have to test. it still does have a few rough edges like, e.g., serum address is only correct in prod

@SvenDowideit SvenDowideit added the needs-test Needs someone to confirm if this is still an issue label May 6, 2022
@nathanleclaire nathanleclaire changed the title Fix or remove program filter Program ID filter for changes broken May 6, 2022
@nathanleclaire
Copy link
Contributor

nathanleclaire commented May 6, 2022

OK so this is indeed broken, but it kinda works. Mainly, the issue seems to be that if you change programs, the old changes don't get cleaned out. If I set it to token program and change nets, I get all token accounts.

This could be kinda sick for PDAs (and start of local telemetry -> local postgres?) so we should keep rolling with it imo.

@nathanleclaire nathanleclaire modified the milestones: 0.3.0, 0.3.1 May 6, 2022
@SvenDowideit SvenDowideit modified the milestones: 0.3.1, 0.4.0 Jun 27, 2022
@nathanleclaire nathanleclaire modified the milestones: 0.4.0, 0.4.1 Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-test Needs someone to confirm if this is still an issue
Projects
None yet
Development

No branches or pull requests

2 participants