Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TaxClass type #27

Closed
kidunot89 opened this issue Apr 11, 2019 · 0 comments
Closed

TaxClass type #27

kidunot89 opened this issue Apr 11, 2019 · 0 comments
Assignees
@kidunot89
Labels
design notes Blueprint and notes for coming feature enhancement New feature or request new mutations Feature adds mutation(s) to the schema new queries Feature adds querie(s) to the schema new types Feature adds a new type(s)

Comments

@kidunot89
Copy link
Member

kidunot89 commented Apr 11, 2019 •
edited
Loading

Design Notes

  • WPEnum type
  • Wraps tax class objects.
  • Used frequently throughout schema.
  • Values stored by the enumeration should be a tax class slug. Eg. zero-rate, standard, reduced-rate
  • Slugs for values stored by the enumeration should be the tax name formatted with WPEnum::get_safe_name. Eg. ZERO_RATE, STANDARD_RATE, REDUCED_RATE.
@kidunot89 kidunot89 added enhancement New feature or request design notes Blueprint and notes for coming feature new queries Feature adds querie(s) to the schema new mutations Feature adds mutation(s) to the schema new types Feature adds a new type(s) labels Apr 11, 2019
@kidunot89 kidunot89 self-assigned this Apr 11, 2019
@kidunot89 kidunot89 changed the title Tax class schema shape TaxClass type Apr 12, 2019
@kidunot89 kidunot89 mentioned this issue Apr 12, 2019
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kidunot89 kidunot89

Labels
design notes Blueprint and notes for coming feature enhancement New feature or request new mutations Feature adds mutation(s) to the schema new queries Feature adds querie(s) to the schema new types Feature adds a new type(s)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kidunot89