Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When caching is enabled, YouTube embeds do not include additional parameters in the returned iFrame #73

Closed
bendesilva opened this issue Apr 16, 2021 · 3 comments

Comments

@bendesilva
Copy link

Untested on other providers, however it appears that when I have caching enabled, the iFrame does not include any of the additional parameters defined in templates (for context I'm trying to add the enablejsapi parameter). I tried flushing and clearing all caches, creating a new entry with a video that had not been embedded on the website before and in all instances the embed didn't include the parameter in the iFrame src. When disabling the cache the parameter appeared as expected.

I did try disabling the cache for an extended time but was quickly rate limited by YouTube.

oEmbed version: 1.3.6
Craft CMS version: 3.6.11.2

@reganlawton
Copy link
Member

@bendesilva sorry for the delay been out due to health issues. I can confirm that the URL is the only key the cache uses and I'll have to hash the options to get this fixed.

@reganlawton
Copy link
Member

You should be able to see the changes on v1.3.8

@bendesilva
Copy link
Author

Thanks @reganlawton, no need to apologise, thanks so much for this fix! Really appreciate your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants