Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-Site Scripting vulnerability in uglifyjs-webpack-plugin plugin #300

Closed
DimalChandrasiri opened this issue Jan 24, 2020 · 2 comments · Fixed by #301
Closed

Cross-Site Scripting vulnerability in uglifyjs-webpack-plugin plugin #300

DimalChandrasiri opened this issue Jan 24, 2020 · 2 comments · Fixed by #301

Comments

@DimalChandrasiri
Copy link
Contributor

Describe the bug
npm audit report will give a moderate security vulnerability for the webpack plugin uglifyjs-webpack-plugin which has an outdated dependency serialize-javascript in it's dependency list.

Vulnerability Report

To Reproduce
Steps to reproduce the behavior:

  1. Go to the root of ìdentity-app` repository.
  2. Run command npm audit to get the report.

Expected behavior
The npm audit command shouldn't have any vulnerabilities listed.

Screenshots
Screenshot 2020-01-24 at 11 44 02

Desktop (please complete the following information):

  • OS: MacOs Catelina
  • Browser: N/A
  • Version: N/A
@thivi
Copy link
Contributor

thivi commented Jan 24, 2020

Looks like this plugin's repo has been archived. It is better to replace this plugin with Terser[1][2].
The uglifyjs-webpack-plugin's repo says that the plugin has been deprecated and asks us to use the Terser plugin.[3]

[1] https://github.com/webpack-contrib/terser-webpack-plugin
[2] webpack-contrib/terser-webpack-plugin#15
[3] https://github.com/webpack-contrib/uglifyjs-webpack-plugin

@jeradrutnam
Copy link
Member

Fixed: #301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants