Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled widgets with invalid positions should raise an error #389

Closed
senorprogrammer opened this issue Feb 15, 2019 · 0 comments
Closed
Labels
🥇 good first issue 💪 improvement "Where we're going, we don't need roads."

Comments

@senorprogrammer
Copy link
Collaborator

senorprogrammer commented Feb 15, 2019

What's the problem?

If the position data is malformatted a widget will silently fail to show up:

    cmdrunner:
        args: []
        cmd: "uptime"
        enabled: true
        position:
        top: 1
        left: 9
        height: 1
        width: 4
        refreshInterval: 300

How did you expect it to behave?

This is effectively the same as height: 0; width: 0 which should be treated as invalid. If a widget is enabled it must have a height/width minimum of 1.

If the widget is enabled and if the position is invalid, then raise an error and do not load.

Operating system

Terminal program & version

WTF version

@senorprogrammer senorprogrammer added 💪 improvement "Where we're going, we don't need roads." 🥇 good first issue labels Feb 15, 2019
@senorprogrammer senorprogrammer changed the title Invalid positions should raise an error Enabled widgets with invalid positions should raise an error Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥇 good first issue 💪 improvement "Where we're going, we don't need roads."
Development

No branches or pull requests

1 participant