Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Hero Unit Images not shifting on mobile #26

Open
osteffich opened this issue May 22, 2015 · 1 comment
Open

Some Hero Unit Images not shifting on mobile #26

osteffich opened this issue May 22, 2015 · 1 comment

Comments

@osteffich
Copy link
Contributor

I noticed that some hero unit patterns aren't shifting the image to the left.

It looks like "Hero" and "Hero Unit with Busy Photo + Vignetting" aren't shifting to the left.

"Hero Unit with Medium Shout and Photo" isn't shifting and it looks like the same image is bumping down below it or something.

"Hero Unit with Shout, Photo, Diagonal Line" is shifting so the right side of the image is visible. This looks like it is working properly. Can the other hero patterns be adjusted so they do the same thing?

@adamglenn
Copy link
Contributor

The Medium Shout thing is happening because there is both a background image and an actual image in the HTML itself. This will dependent on how you use the hero unit. So if you just use the image as a CSS background on the hero, this is not an issue. If you use an actual image in there, then you will need to turn off the background image and adjust the min-height of the image you put in the HTML. This will vary depending on the amount of copy you have in your hero unit. So there is no one-size-fits-all solution that I know of. Same goes for the image shift. How much the image shifts will depend on the composition of the image. So you will have to adjust that on your end. I can make a comment to document this issue in the patterns, but I don't know if there is an easy solution for everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants