Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ARIA labels to main header, backpage header, breadcrumbs #109

Closed
adamglenn opened this issue May 31, 2019 · 3 comments
Closed

Add ARIA labels to main header, backpage header, breadcrumbs #109

adamglenn opened this issue May 31, 2019 · 3 comments
Assignees
@adamglenn
Labels
bug Something isn't working

Comments

@adamglenn
Copy link
Contributor

No description provided.

@adamglenn adamglenn added the bug Something isn't working label May 31, 2019
@adamglenn adamglenn self-assigned this May 31, 2019
@adamjohnson
Copy link
Contributor

Why add aria-label="masthead" to the <header> tag? Are there multiple <header> tags?

https://github.com/wvuweb/wvu-design-system/blob/master/views/layouts/default.html#L42

If not, aria-label can be omitted.

@adamglenn
Copy link
Contributor Author

It does when you have a backpage header. I can make it dependent.

@adamglenn
Copy link
Contributor Author

Unless it is more appropriate to use a different HTML tag in either situation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamglenn adamglenn

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adamjohnson @adamglenn