Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove package-lock.json and add stars (*) to devDependencies in package.json #14

Closed
adamjohnson opened this issue Feb 4, 2019 · 0 comments
Assignees

Comments

@adamjohnson
Copy link
Contributor

Steps to reproduce the issue

View package-lock.json and package.json at the root of the project.

Results

Both of these files are locking the major version numbers of the packages they use.

Expected results

With the exception of Gulp (?), other devDependencies should not list a version number in package.json. It should list a star (*), like so:

{
  "devDependencies": {
    "gulp": "^3.9.1",
    "gulp-sass": "*"
  }
}

package-lock.json should be deleted from this repo. It will be created per-project upon npm install.

By following these guidelines, it will:

  • Ensure we're using the latest versions of the requisite packages
  • Help with compatability (using old tech > stuff doesn't work > solution = update to latest version)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants