Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Featurettes CleanSlate Component doesn't work #166

Closed
adamjohnson opened this issue Jul 22, 2019 · 5 comments
Closed

Featurettes CleanSlate Component doesn't work #166

adamjohnson opened this issue Jul 22, 2019 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@adamjohnson
Copy link
Contributor

Steps to reproduce the issue

  1. Log into CleanSlate and navigate to a site that uses the design system.
  2. Go to Pages > Properties > Custom Data
  3. Add the Featurettes Component to a slot. Set the Slot Limit to 3 (or any number).
  4. Save the Page Properties and open the page to edit.

Results

Featurettes do not show. The featurette's headline and other editable regions show; however, the columns do not show.

Expected Results

The featurettes columns should show for featurettes.

cc @ktduong & @rebecca-patton

@adamjohnson adamjohnson added the bug Something isn't working label Jul 22, 2019
@adamglenn
Copy link
Contributor

adamglenn commented Jul 22, 2019

This is a problem with the documentation. You have to add a label to each page you want to display in a featurette, so the featurette knows what to display e.g. {slug-of-page-you-want-it-to-display-on}-featurettes-{instance-number} i.e. home-featurettes-1 if you want to add featurettes in the meantime. Will update docs tomorrow. cc @ktduong & @rebecca-patton

@adamjohnson
Copy link
Contributor Author

Also note that the new featurette component replaces the old “polyptych” patterns. These patterns allowed the designer to specify a number of panels that each contained editable regions (for the thumbnail image, photo, etc.). Now you just use a featurettes component and set its style to “Editable regions” in the Super Theme or the featurettesStyle to editable-regions.

From How Featurettes Work.

I only needed a triptych, not necessarily to pull pages. Switching the style to "Editable regions" was the key part.

Thank you for the help, especially on your day off.

@rebecca-patton
Copy link

I'm trying to pass variables to the partials manually, and the columns still aren't showing up for me.

Steps to reproduce the issue

Log into CleanSlate and navigate to a site that uses the design system.
Open a page template (i.e. frontpage.html) in your code editor.
Insert the Featurettes partial and variables after the site data:

<r:set_var name="componentLimit" value="4" />
<r:set_var name="componentFeaturettesStyle" value="editable-regions" />
<r:partial name="components/wvu-featurettes" theme="University Relations: WVU Design System" />

Commit changes and update the theme in CleanSlate.

Results

Featurettes do not show. The featurette's headline and other editable regions show; however, the columns do not show.

Expected Results

The featurettes columns should show for featurettes.

@adamglenn
Copy link
Contributor

K, I'll take a look tomorrow.

@adamglenn adamglenn reopened this Jul 22, 2019
@adamglenn
Copy link
Contributor

adamglenn commented Jul 23, 2019

So I screwed up the variable names on this docs page: https://designsystem.wvu.edu/tutorials/building-templates-using-shared-partials (I assume that is what you were referencing)

Should be:

<r:set_var name="limit" value="4" />
<r:set_var name="featurettesStyle" value="editable-regions" />
<r:partial name="components/wvu-featurettes" theme="University Relations: WVU Design System" />

I have updated the docs: https://designsystem.wvu.edu/tutorials/building-templates-using-shared-partials?=53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants