Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masthead should contain "West Virginia University" in addition to the site title #227

Closed
adamjohnson opened this issue Dec 19, 2019 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@adamjohnson
Copy link
Contributor

In previous themes (Brand Patterns, Super Theme), the masthead included the words "West Virginia University" like so:

<a class="wvu-masthead__logo" href="/">
  <span class="wvu-masthead__university-name">West Virginia University</span>
  <span class="wvu-masthead__title">Undergraduate Admissions</span>
</a>

The issue

The design system shows a logo that uses the WVU logo (which says the words "West Virginia University") but doesn't output the words anywhere in the source.

<a class="d-flex position-relative my-3 align-items-center justify-content-center justify-content-lg-start text-decoration-none text-white" href="/">
  <div class="wvu-logo-lockup mt-n1">
    Undergraduate Admissions
  </div>
</a>

The fix

We should output the words "West Virginia University" in a span tag with the .sr-only class in the masthead. This will make the masthead more accessible.

@adamjohnson adamjohnson added the bug Something isn't working label Dec 19, 2019
@adamjohnson adamjohnson self-assigned this Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant