Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace nav with the one from wvu.edu. #25

Closed
adamglenn opened this issue Feb 14, 2019 · 2 comments
Closed

Replace nav with the one from wvu.edu. #25

adamglenn opened this issue Feb 14, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@adamglenn
Copy link
Contributor

Is better for usability. Also restyle the plus sign.

@adamglenn adamglenn added the enhancement New feature or request label Feb 14, 2019
@adamjohnson
Copy link
Contributor

adamjohnson commented Feb 14, 2019

FYI I also implemented this in Brand Patterns, starting at v1.5.0 and put a few enhancements in for v1.6.0.

Commit log starting from July 5th, 2018: https://github.com/wvuweb/brand-patterns/commits/master

Vendor JS: https://github.com/wvuweb/brand-patterns/blob/master/javascripts/vendor/responsive-nav-dropdown.js

WVU's Custom Dropdown JS: https://github.com/wvuweb/brand-patterns/blob/master/javascripts/responsive-nav-dropdown--custom.js

Relevant Dropdown Sass: https://github.com/wvuweb/brand-patterns/blob/master/scss/1-base/_wvu-nav-dropdowns.scss

☝️ NOTE: Specifically disabling menus beyond the second level for UI/UX reasons (see the comments in that file). I figured people can dig in and enable it if they're really keen on having hover menus for their hover menus.

Relevant HTML: https://github.com/wvuweb/brand-patterns/blob/master/views/patterns/_wvu-nav-dropdowns.html


FWIW, I like the + and - signs for mobile. We're already using arrows to denote the presence of a dropdown, so using another ▶️ would muddy the waters IMO.

@adamjohnson
Copy link
Contributor

If you click "Menu" on Virginia Tech's Homepage, they have a + / × pattern. Also works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants