You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This code puts an editable region for keywords for the Big Search component.
Expected results
Instead of having this in the default layout (and thus having to process the value of the $enable_keywords variable and resulting radius code), this should be moved to the Big Search partial and inserted into the layout via page_js with <r:content_for>.
The hope here is to minimize the amount of processing CleanSlate has to do for every single page; thus, improving performance (in this case, Time to First Byte / Server Response Time).
This also tightly couples this code together with its component and makes it less confusing as to what it is.
The text was updated successfully, but these errors were encountered:
This code doesn’t apply to pages with the Big Search component, but any page in the site that is searchable by that component. The Big Search searches the keyword editable region of other pages and displays pages with those keywords on a Big Search Results page. So it could be any page that needs the region.
What should happen is that this code should just be omitted by default and inserted only into themes that use the Big Search, since we are encouraging people to do stuff manually now anyways, and the Big Search is seldom used.
Steps to reproduce the issue
default.html
Results
This code puts an editable region for keywords for the Big Search component.
Expected results
Instead of having this in the default layout (and thus having to process the value of the
$enable_keywords
variable and resulting radius code), this should be moved to the Big Search partial and inserted into the layout viapage_js
with<r:content_for>
.The hope here is to minimize the amount of processing CleanSlate has to do for every single page; thus, improving performance (in this case, Time to First Byte / Server Response Time).
This also tightly couples this code together with its component and makes it less confusing as to what it is.
The text was updated successfully, but these errors were encountered: