Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile template/component doesn't have configurable alt text for headshots #279

Closed
adamjohnson opened this issue Aug 6, 2020 · 0 comments
Closed

Profile template/component doesn't have configurable alt text for headshots #279

adamjohnson opened this issue Aug 6, 2020 · 0 comments
Assignees
@adamjohnson
Labels
bug Something isn't working

Comments

@adamjohnson
Copy link
Contributor

Profile template screenshot

Steps to reproduce the issue

  1. Create a profile page and fill out all the requisite fields.
  2. Be sure to fill in the alt text in Page Properties > Custom Data.

Results

The profile image has a hardcoded alt text value of thumbnail_alt. You can see this in views/components/_wvu-profile.html lines 41 and 45.

Expected results

Instead of the alt text value being thumbnail_alt, it should be <r:page:data name="thumbnail_alt" />.

For easy copy paste:

alt="<r:page:data name="thumbnail_alt" />"
@adamjohnson adamjohnson added the bug Something isn't working label Aug 6, 2020
@adamjohnson adamjohnson self-assigned this Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamjohnson adamjohnson

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adamjohnson