Fix success status when action failed #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exit code of the script should be the exit code of the `firebase ` command. The easiest way to achieve that is to have `firebase` be the last command in the script. I've removed the (conditional) token deprecation warning output at the end of the script, because it's a duplicate, the warning is still given before the `firebase` command is executed.
|
Thanks! |
|
I guess you'll still need to merge this. I don't have permission. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #109
Closes: #101
Originally posted by @kaibolay in #110
I've cherry-picked the original commit to run tests. Then, I added a test for the "action failed" scenario.