Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom pagination #326

Closed
1 task done
VictorCazanave opened this issue Jul 4, 2018 · 4 comments
Closed
1 task done

Custom pagination #326

VictorCazanave opened this issue Jul 4, 2018 · 4 comments
Assignees

Comments

@VictorCazanave
Copy link
Contributor

Issue Type

  • Enhancement Request

Specs

What version are you using?
2.4.5

What browser?
Last 2 versions, IE >= 10, Safari >= 7

Expected Behavior

What did you expect to happen?

In my project I need to display a pagination that is pretty different than the one provided (first/last page buttons, refresh button, more labels, different elements position...).
Would it be possible to add a slot to customize the pagination (like the columns headers)?

Of course if you use a custom pagination template, you will have to implement your own pagination system.

Since this component fits all my other needs, I would like to keep it and avoid to make my own component or fork this project.
If you agree with this feature but don't have time, I would be glad to (try to) contribute.

@xaksis
Copy link
Owner

xaksis commented Jul 6, 2018

@VictorCazanave this isn't on the roadmap and I don't think I'll have time to tackle this any time soon. feel free to submit a PR for this and I'll review.

@VictorCazanave
Copy link
Contributor Author

Hi @xaksis ! Actually I had some free time, so I've already submitted a PR (#327) 😄

@xaksis
Copy link
Owner

xaksis commented Jul 16, 2018

@VictorCazanave thanks for your help! v2.9.0 now contains your PR.

closing.

@xaksis xaksis closed this as completed Jul 16, 2018
@VictorCazanave
Copy link
Contributor Author

@xaksis Thanks for your time and this great component!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants