Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI workflows #8

Open
3 of 4 tasks
andersy005 opened this issue Jul 28, 2022 · 5 comments · May be fixed by #45
Open
3 of 4 tasks

Add CI workflows #8

andersy005 opened this issue Jul 28, 2022 · 5 comments · May be fixed by #45

Comments

@andersy005
Copy link
Member

andersy005 commented Jul 28, 2022 •
edited
Loading

  • Add pre-commit configuration
  • Remove versioneer and use setuptools-scm
  • Add Github workflow for testing infrastructure
  • Rename branch from master -> main
@jakirkham
Copy link
Collaborator

jakirkham commented Jul 29, 2022 •
edited
Loading

Curious could you please share some more context on the preference of setuptools-scm over versioneer?

@andersy005
Copy link
Member Author

andersy005 commented Jul 29, 2022 •
edited
Loading

Curious could you please share some more context on the preference of setuptool-scm over versioneer?

The last time i used it (late 2019), versioneer was no longer actively maintained but it appears its development has resumed and some of the missing features (e.g. python-versioneer/python-versioneer#146) seem to be on the roadmap. So, perhaps this change isn't necessary

@jakirkham
Copy link
Collaborator

jakirkham commented Jul 29, 2022 •
edited
Loading

Recall there being some edge cases with setuptools-scm. In particular sdists would need to be generated and uploaded to PyPI for downstream packagers to make sure they have access to version info when building packages (as GitHub archives wouldn't include this for example).

@keewis
Copy link
Contributor

keewis commented Jul 29, 2022

that particular issue has been fixed in recent versions of setuptools-scm, but still requires additional configuration

@jacobtomlinson
Copy link
Collaborator

Versioneer picked up development again and has been good lately. I'm continuing to use it in other projects over setuptools-scm.

dcherian added a commit that referenced this issue Aug 17, 2022
@dcherian
Update versioneer
a5e2a70 
xref #8
@dcherian dcherian mentioned this issue Aug 17, 2022
Merged
@andersy005 andersy005 mentioned this issue Aug 17, 2022
Merged
This was referenced Jun 22, 2024
Draft
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Setup GitHub Action Continuous Integration tests xarray-contrib/cupy-xarray
4 participants
@jacobtomlinson @jakirkham @andersy005 @keewis