Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin version comparison should work for all cases #597

Closed
xen0l opened this issue Oct 16, 2020 · 0 comments · Fixed by #599
Closed

Plugin version comparison should work for all cases #597

xen0l opened this issue Oct 16, 2020 · 0 comments · Fixed by #599

Comments

@xen0l
Copy link
Owner

xen0l commented Oct 16, 2020

Current version of plugin has version 1.2.7.0. My version is quite old, 1.1.23.0. Under the current logic (remove dots and do a simple comparison), 1.2.7.0 is older than 1.1.23.0.
@xen0l xen0l changed the title Plugin version comparison should be better Plugin version comparison should work for all cases Oct 16, 2020
@xen0l xen0l mentioned this issue Oct 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Plugin version comparison should work for all cases xen0l/aws-gate
1 participant
@xen0l