Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrapped plugin not found in PATH #598

Closed
xen0l opened this issue Oct 16, 2020 · 1 comment · Fixed by #601
Closed

Bootstrapped plugin not found in PATH #598

xen0l opened this issue Oct 16, 2020 · 1 comment · Fixed by #601

Comments

@xen0l
Copy link
Owner

xen0l commented Oct 16, 2020

The current behaviour is that plugin found in the PATH will be used the first. However, if there is no plugin present in the PATH and we have plugin installed via aws-gate bootstrap we should use it as a last resort.
@xen0l xen0l changed the title Bootstrapaped plugin should be tried as a last resort Bootstraped plugin should be tried as a last resort Oct 16, 2020
@xen0l xen0l changed the title Bootstraped plugin should be tried as a last resort Bootstrapped plugin should be tried as a last resort Oct 16, 2020
@xen0l
Copy link
Owner Author

xen0l commented Oct 17, 2020

Further analysis showed that the change #572 resulted in env=None, thus os.environ never contained ~/.aws-gate/bin in PATH.

@xen0l xen0l mentioned this issue Oct 17, 2020
Merged
@xen0l xen0l changed the title Bootstrapped plugin should be tried as a last resort Bootstrapped plugin not found in PATH Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix env=None introduced in #572 xen0l/aws-gate
1 participant
@xen0l