Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample load crash #373

Closed
Float-pixel opened this issue Feb 12, 2025 · 1 comment · Fixed by #378
Closed

sample load crash #373

Float-pixel opened this issue Feb 12, 2025 · 1 comment · Fixed by #378
Assignees
Labels
2.0-beta audio concerns audio engine or playback bug Something isn't working

Comments

@Float-pixel
Copy link

Float-pixel commented Feb 12, 2025

sample crash log.txt

if you audition a sample, then try to load the same sample while the audition is still going on, it can cause a crash.

I can reproduce this by making a new project, random name, make instrument 00 sample, audition a sample long enough to then try to load the sample while still auditioning. attached is a serial log.

This seems to happen specifically in new projects. Can be worked around by simply waiting for auditions to end before loading.

@maks maks self-assigned this Feb 12, 2025
@maks maks added bug Something isn't working audio concerns audio engine or playback 2.0-beta labels Feb 12, 2025
@maks
Copy link
Collaborator

maks commented Feb 12, 2025

I'm pretty sure I know already why this happens: the file system is not intended to be accessed simultaneously from both cpu cores so there is a mutex to prevent that. But that would be exactly what would happen in this case as sample preview happens on core1 (audio rendering) while the file copy operation for importing a sample would be on core0 and so at best would stall core0 until the audio preview playback finished.
Instead we just need to add a check that prevents starting sample import if sample preview playback is in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0-beta audio concerns audio engine or playback bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants