From fb513665e03076aad1f2c11ea41b57aa63c0ee17 Mon Sep 17 00:00:00 2001 From: Nick Hill <nickhill@us.ibm.com> Date: Tue, 26 Mar 2024 14:39:44 -0700 Subject: [PATCH] [BugFix] Fix ipv4 address parsing regression (#3645) --- vllm/utils.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/vllm/utils.py b/vllm/utils.py index 4899b9074060e..83d94f2800448 100644 --- a/vllm/utils.py +++ b/vllm/utils.py @@ -205,7 +205,9 @@ def get_ip() -> str: def get_distributed_init_method(ip: str, port: int) -> str: - return f"tcp://[{ip}]:{port}" + # Brackets are not permitted in ipv4 addresses, + # see https://github.com/python/cpython/issues/103848 + return f"tcp://[{ip}]:{port}" if ":" in ip else f"tcp://{ip}:{port}" def get_open_port() -> int: