libfacedetection: add package #2773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waruqi
reviewed
Oct 31, 2023
| add_configs("neon", {description = "Use neon", default = true, type = "boolean"}) | ||
| else | ||
| add_configs("avx512", {description = "Use avx512", default = false, type = "boolean"}) | ||
| add_configs("avx2", {description = "Use avx2", default = true, type = "boolean"}) |
There was a problem hiding this comment.
没必要根据 arch 去增删 configs 。。这也不便于 包配置信息的查看，用户端也得根据 arch 去判断处理。
你直接根据 arch 设置 default true/false 就行了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.