dpp: update to v10.0.29 #2938
Merged
dpp: update to v10.0.29 #2938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It does not work for windows. |
|
How to explicitly exclude arm builds for windows ? |
waruqi
reviewed
Dec 12, 2023
packages/d/dpp/xmake.lua
Outdated
| @@ -78,6 +79,10 @@ package("dpp") | |||
| if package:version():ge("v10.0.23") then | |||
| package:add("defines", "DPP_USE_EXTERNAL_JSON") | |||
| end | |||
|
|
|||
| if package:version():ge("v10.0.29") and is_plat("windows") then | |||
waruqi
reviewed
Dec 12, 2023
packages/d/dpp/xmake.lua
Outdated
| @@ -78,6 +79,10 @@ package("dpp") | |||
| if package:version():ge("v10.0.23") then | |||
| package:add("defines", "DPP_USE_EXTERNAL_JSON") | |||
| end | |||
|
|
|||
| if package:version():ge("v10.0.29") and is_plat("windows") then | |||
| package:add("cxxflags", "/bigobj /Gy") | |||
There was a problem hiding this comment.
you should pass flags to tools.xmake instead of user project.
local cxflags
if package:is_plat("windows") then
cxflags = {"/bigobj", "/Gy"}
end
import("package.tools.xmake").install(package, {}, {cxflags = cxflags})There was a problem hiding this comment.
This change doesn't seem to have any effect on the build, the "Windows 2019 shared x64" one is still failing because of the error above 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.